-
Notifications
You must be signed in to change notification settings - Fork 22
Ttonev/fix both side pin sample #3761
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 11 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
14b1889
fix(sample): fix pin buttons to update pin state
tishko0 3c826f8
Merge pull request #3795 from IgniteUI/vnext
ChronosSF c5d0585
Merge pull request #3838 from IgniteUI/vnext
ChronosSF 4d5b972
Merge pull request #3841 from IgniteUI/vnext
ChronosSF ec79aae
Merge branch 'vnext' into ttonev/fix-both-side-pin-sample
tishko0 d1a05a0
fix(lob): import IgxCategoryChartModule instead of core
ddaribo a7dd135
Merge pull request #3867 from IgniteUI/bpachilova/fix-grid-master-det…
ChronosSF 6904863
refactor(sample): Changed pin methods to use api instead
tishko0 1b0b18d
Merge branch 'vnext', remote-tracking branch 'origin' into ttonev/fix…
tishko0 08bcf16
Merge branch 'ttonev/fix-both-side-pin-sample' of https://github.com/…
tishko0 963563e
chore(both-side-pin): add data for Region field
b86582e
fix(sample): added pining via pai for hgrid & tgrid
tishko0 92f8707
Merge branch 'ttonev/fix-both-side-pin-sample' of https://github.com/…
tishko0 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -38,13 +38,15 @@ export class TreeGridBothSidesPinningSampleComponent implements OnInit { | |
|
|
||
| public pinLeft() { | ||
| this.grid1.selectedColumns().forEach((col: IgxColumnComponent) => { | ||
| col.pinned = false; | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Also here pls |
||
| col.pinningPosition = ColumnPinningPosition.Start; | ||
| col.pinned = true; | ||
| }); | ||
| } | ||
|
|
||
| public pinRight() { | ||
| this.grid1.selectedColumns().forEach((col: IgxColumnComponent) => { | ||
| col.pinned = false; | ||
| col.pinningPosition = ColumnPinningPosition.End; | ||
| col.pinned = true; | ||
| }); | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also here pls