-
Notifications
You must be signed in to change notification settings - Fork 22
Ttonev/fix both side pin sample #3761
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: vnext
Are you sure you want to change the base?
Conversation
Updating Master with changes from Vnext
Updating prod with changes from staging
Updating latest fixes from staging to prod
…ail-chart-3823-master fix(lob): import IgxCategoryChartModule instead of IgxCategoryChartCoreModule - master
|
Looks good for me now. But please update the branch and also maybe try the approach that we discussed with you and @MayaKirova |
|
|
||
| public pinLeft() { | ||
| this.grid1.selectedColumns().forEach((col: IgxColumnComponent) => { | ||
| col.pinned = false; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could just use the api instead of changing the props. The column has pin method API.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
…-both-side-pin-sample
…IgniteUI/igniteui-angular-samples into ttonev/fix-both-side-pin-sample
|
|
||
| public pinLeft() { | ||
| this.grid1.selectedColumns().forEach((col: IgxColumnComponent) => { | ||
| col.pinned = false; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also here pls
|
|
||
| public pinLeft() { | ||
| this.grid1.selectedColumns().forEach((col: IgxColumnComponent) => { | ||
| col.pinned = false; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also here pls
fixes #3758