Skip to content

Conversation

@samford
Copy link
Member

@samford samford commented Nov 1, 2025

Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.

In the following questions <cask> is the token of the cask you're submitting.

After making any changes to a cask, existing or new, verify:

Additionally, if adding a new cask:

  • Named the cask according to the token reference.
  • Checked the cask was not already refused (add your cask's name to the end of the search field).
  • brew audit --cask --new <cask> worked successfully.
  • HOMEBREW_NO_INSTALL_FROM_API=1 brew install --cask <cask> worked successfully.
  • brew uninstall --cask <cask> worked successfully.

shotcut is autobumped but the workflow failed to update to version 25.12.31 because the file name now includes the version with dots. This updates the version and url accordingly.

Copilot AI review requested due to automatic review settings November 1, 2025 02:36

This comment was marked as outdated.

@bevanjkay bevanjkay added ci-retry Continuously re-runs CI until it succeeds or is cancelled. and removed ci-retry Continuously re-runs CI until it succeeds or is cancelled. labels Nov 2, 2025
@bevanjkay bevanjkay force-pushed the shotcut-25.10.31 branch 2 times, most recently from 3cca057 to 303e2ec Compare November 24, 2025 06:33
@github-actions

This comment was marked as outdated.

@github-actions github-actions bot added the stale Issue which has not received any feedback for some time. label Dec 31, 2025
@github-actions github-actions bot removed the stale Issue which has not received any feedback for some time. label Dec 31, 2025
@samford samford changed the title shotcut 25.10.31 shotcut 25.12.30 Dec 31, 2025
@samford
Copy link
Member Author

samford commented Dec 31, 2025

I updated this to 25.12.30 and tinkered with this some more and it seems like there isn't a winning combination of changes that will allow brew audit to pass in CI (it works fine for both archs locally on macOS 26 ARM).

  • With shotcut removed from signing_audit_skiplist.json: macOS 26 (ARM) passes but macOS 15 (Intel) inexplicably errors with "Signature verification failed".
  • With shotcut not removed from signing_audit_skiplist.json: macOS 15 (Intel) passes but macOS 26 (ARM) fails with "Cask is in the signing audit skiplist, but does not need to be skipped!"

Not sure how to best proceed here, as the audit for Intel works fine locally and only fails in CI (similar to a few other casks that inexplicably fail signature checks only in CI).

`shotcut` is autobumped but the workflow failed to update to version
25.12.31 because the file name now includes the version with dots.
This updates the version and `url` accordingly.
@khipp khipp force-pushed the shotcut-25.10.31 branch from 6d39327 to b4dae39 Compare January 1, 2026 14:50
@khipp khipp changed the title shotcut 25.12.30 shotcut 25.12.31 Jan 1, 2026
@khipp
Copy link
Member

khipp commented Jan 1, 2026

Not sure how to best proceed here, as the audit for Intel works fine locally and only fails in CI (similar to a few other casks that inexplicably fail signature checks only in CI).

Since we have seen quite a few of those issues, would it make sense to allow for a more fine-grained skiplist, similar to what we do in github_prerelease_allowlist.json? We could allow setting specific architectures, e.g., arm, intel, or all.

If it also depends on the runner's macOS version, we could be less strict about list entries in general and turn "Cask is in the signing audit skiplist, but does not need to be skipped!" into a warning.

@samford samford mentioned this pull request Jan 8, 2026
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants