Conversation
Member
Author
|
If we needed any indicator that the signing audit is flaky on macOS 15 Intel, failing on an app from Apple is a pretty good indicator 😆 |
Member
|
Maybe we just only run the audit on CI the |
Member
Author
So long as there isn't a technical need to run the signing audit on a specific OS version/arch for it to be correct, that could make sense. I'm not knowledgeable in this area, so it would be good for someone else to weigh in. Klaus also proposed adding a skiplist for this. I don't have any particular ideas but it's something that we'll have to address in some way, as it's a recurring issue (e.g., I now have three open PRs that can't be merged because of it). |
`icon-composer` is autobumped but the workflow failed to update to version 1.2 because the `livecheck` block produces an "Unable to get versions" error, as the homepage no longer lists any version information. The download links direct to a page that lists Icon Composer versions (with links to the dmg files) but this is behind a login, so we can't check it. This updates the cask to 1.2 and sets the `livecheck` block to skip, as there doesn't appear to be any checkable source of version information at the moment.
The signing audit reliably fails on Intel in CI, so we have to skip it for CI to pass.
samford
force-pushed
the
icon-composer-1.2
branch
from
4884aa0 to
21e64f7
Compare
bevanjkay
approved these changes
Jan 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.
In the following questions
<cask>is the token of the cask you're submitting.After making any changes to a cask, existing or new, verify:
brew audit --cask --online <cask>is error-free.brew style --fix <cask>reports no offenses.Additionally, if adding a new cask:
brew audit --cask --new <cask>worked successfully.HOMEBREW_NO_INSTALL_FROM_API=1 brew install --cask <cask>worked successfully.brew uninstall --cask <cask>worked successfully.icon-composeris autobumped but the workflow failed to update to version 1.2 because thelivecheckblock produces an "Unable to get versions" error, as the homepage no longer lists any version information. The download links direct to a page that lists Icon Composer versions (with links to the dmg files) but this is behind a login, so we can't check it. This updates the cask to 1.2 and sets thelivecheckblock to skip, as there doesn't appear to be any checkable source of version information at the moment.