Skip to content

test(appengine/storage): remove public ACL assignment to comply with public access prevention #4327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
angelcaamal wants to merge 1 commit into
base: main
Choose a base branch
from
+3 −18
Open

test(appengine/storage): remove public ACL assignment to comply with public access prevention #4327

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 1 addition & 6 deletions appengine/storage/flexible/system-test/app.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,12 +32,7 @@ const requestObj = supertest(proxyquire(path.join(cwd, 'app'), {process}));

before(async () => {
try {
await bucket.create(bucket).then(() => {
return bucket.acl.add({
entity: 'allUsers',
role: Storage.acl.READER_ROLE,
});
});
await bucket.create();
} catch (err) {
if (
!err.message.match(
Expand Down
7 changes: 1 addition & 6 deletions appengine/storage/flexible_nodejs16_and_earlier/system-test/app.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,12 +32,7 @@ const requestObj = supertest(proxyquire(path.join(cwd, 'app'), {process}));

before(async () => {
try {
await bucket.create(bucket).then(() => {
return bucket.acl.add({
entity: 'allUsers',
role: Storage.acl.READER_ROLE,
});
});
await bucket.create();
} catch (err) {
if (
!err.message.match(
Expand Down
7 changes: 1 addition & 6 deletions appengine/storage/standard/system-test/app.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,12 +32,7 @@ const requestObj = supertest(proxyquire(path.join(cwd, 'app'), {process}));

before(async () => {
try {
await bucket.create(bucket).then(() => {
return bucket.acl.add({
entity: 'allUsers',
role: Storage.acl.READER_ROLE,
});
});
await bucket.create();
} catch (err) {
if (
!err.message.match(
Expand Down
Loading