test(appengine/storage): remove public ACL assignment to comply with public access prevention#4327
Open
angelcaamal wants to merge 1 commit into
Open
test(appengine/storage): remove public ACL assignment to comply with public access prevention#4327angelcaamal wants to merge 1 commit into
angelcaamal wants to merge 1 commit into
Conversation
…public access prevention
Contributor
There was a problem hiding this comment.
Code Review
This pull request simplifies the test setup across multiple App Engine storage system tests by removing the explicit ACL configuration and argument passing when creating a storage bucket, changing bucket.create(bucket) to a simpler bucket.create(). There are no review comments, and I have no additional feedback to provide.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes a CI test failure in the
appengine/storagesample caused by a security policy violation during the test setup.Why is this needed?
The
beforehook in the test suite was attempting to assign theallUsersrole to the newly created temporary bucket. Because the CI project environment enforces Public Access Prevention, the Google Cloud Storage API immediately rejected this operation with the following error:Error: The member bindings allUsers and allAuthenticatedUsers are not allowed since public access prevention is enforced.Fixes Internal: b/517226702
Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.
Checklist
npm test(see Testing)npm run lint(see Style)GoogleCloudPlatform/nodejs-docs-samples. Not a fork.