Skip to content

fix(Test): update test exception #185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BotellaA merged 1 commit into from
May 7, 2026
Merged

fix(Test): update test exception #185

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 8 additions & 5 deletions tests/mesh/test-csv.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,40 +36,43 @@
#include <geode/mesh/io/point_set_input.hpp>
#include <geode/mesh/io/point_set_output.hpp>

void test_csv_input()

Check warning on line 39 in tests/mesh/test-csv.cpp

View workflow job for this annotation

GitHub Actions / test / tidy

tests/mesh/test-csv.cpp:39:6 [misc-use-internal-linkage] 

function 'test_csv_input' can be made static or moved into an anonymous namespace to enforce internal linkage
{
const auto filepath =
absl::StrCat( geode::DATA_PATH, "top_granitoid_vertices.csv" );
const auto additional_files =
geode::point_set_additional_files< 3 >( filepath );
OPENGEODE_EXCEPTION( additional_files.has_additional_files(),
geode::OpenGeodeIOMeshException::test(
additional_files.has_additional_files(),
"[TEST: CSV input], Additional files should be present" );
auto point_set = geode::load_point_set< 3 >( filepath );
OPENGEODE_EXCEPTION( point_set->nb_vertices() == 103455,
geode::OpenGeodeIOMeshException::test( point_set->nb_vertices() == 103455,

Check warning on line 49 in tests/mesh/test-csv.cpp

View workflow job for this annotation

GitHub Actions / test / tidy

tests/mesh/test-csv.cpp:49:72 [cppcoreguidelines-avoid-magic-numbers] 

103455 is a magic number; consider replacing it with a named constant
"[TEST: CSV input], "
"The point set should have 103455 vertices found",
point_set->nb_vertices() );
geode::save_point_set( *point_set, "result.og_pts3d" );
}

void test_csv_input_with_missing_json()

Check warning on line 56 in tests/mesh/test-csv.cpp

View workflow job for this annotation

GitHub Actions / test / tidy

tests/mesh/test-csv.cpp:56:6 [misc-use-internal-linkage] 

function 'test_csv_input_with_missing_json' can be made static or moved into an anonymous namespace to enforce internal linkage
{
const auto filepath =
absl::StrCat( geode::DATA_PATH, "other_geological_pointset3d.csv" );
const auto additional_files =
geode::point_set_additional_files< 3 >( filepath );
OPENGEODE_EXCEPTION( !additional_files.has_additional_files(),
geode::OpenGeodeIOMeshException::test(
!additional_files.has_additional_files(),
"[TEST: CSV input], Additional files should be missing because of a "
"missing keyword" );
}

void test_csv_input_with_missing_keyword()

Check warning on line 68 in tests/mesh/test-csv.cpp

View workflow job for this annotation

GitHub Actions / test / tidy

tests/mesh/test-csv.cpp:68:6 [misc-use-internal-linkage] 

function 'test_csv_input_with_missing_keyword' can be made static or moved into an anonymous namespace to enforce internal linkage
{
const auto filepath =
absl::StrCat( geode::DATA_PATH, "mising_keyword.csv" );
const auto additional_files =
geode::point_set_additional_files< 3 >( filepath );
OPENGEODE_EXCEPTION( !additional_files.has_additional_files(),
geode::OpenGeodeIOMeshException::test(
!additional_files.has_additional_files(),
"[TEST: CSV input], Additional files should be missing because of a "
"missing keyword" );
}
Expand All @@ -78,7 +81,7 @@
{
try
{
geode::IOMeshLibrary::initialize();
geode::OpenGeodeIOMeshLibrary::initialize();
geode::Logger::set_level( geode::Logger::LEVEL::trace );
test_csv_input();
test_csv_input_with_missing_json();
Expand Down
Loading