Skip to content

fix(Test): update test exception#185

Open
BotellaA wants to merge 1 commit intonextfrom
fix/v17
Open

fix(Test): update test exception#185
BotellaA wants to merge 1 commit intonextfrom
fix/v17

Conversation

@BotellaA
Copy link
Copy Markdown
Member

@BotellaA BotellaA commented May 7, 2026

No description provided.

@BotellaA BotellaA requested a review from panquez May 7, 2026 11:23
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 7, 2026

Cpp-Linter Report ⚠️

Some files did not pass the configured checks!

clang-tidy (v20.1.8) reports: 4 concern(s)
  • tests/mesh/test-csv.cpp:39:6: warning: [misc-use-internal-linkage]

    function 'test_csv_input' can be made static or moved into an anonymous namespace to enforce internal linkage

       39 | void test_csv_input()
          |      ^
          | static 
  • tests/mesh/test-csv.cpp:49:72: warning: [cppcoreguidelines-avoid-magic-numbers]

    103455 is a magic number; consider replacing it with a named constant

       49 |     geode::OpenGeodeIOMeshException::test( point_set->nb_vertices() == 103455,
          |                                                                        ^
  • tests/mesh/test-csv.cpp:56:6: warning: [misc-use-internal-linkage]

    function 'test_csv_input_with_missing_json' can be made static or moved into an anonymous namespace to enforce internal linkage

       56 | void test_csv_input_with_missing_json()
          |      ^
          | static 
  • tests/mesh/test-csv.cpp:68:6: warning: [misc-use-internal-linkage]

    function 'test_csv_input_with_missing_keyword' can be made static or moved into an anonymous namespace to enforce internal linkage

       68 | void test_csv_input_with_missing_keyword()
          |      ^
          | static 

Have any feedback or feature suggestions? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants