Skip to content

Figure.plot: Add alias "fill_between" for option -M #3169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
seisman merged 8 commits into from
Apr 10, 2026
+5 −0
Merged

Figure.plot: Add alias "fill_between" for option -M #3169

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
54f387f
Add alias 'fillcurve' for 'M' of 'plot'
yvonnefroehlich Apr 14, 2024
02d0151
Fix typo
yvonnefroehlich Apr 14, 2024
85d91b7
Fix line length
yvonnefroehlich Apr 14, 2024
ab9a7b8
Merge branch 'main' into add-plot-alias-M
yvonnefroehlich Apr 18, 2024
75aa04a
Merge branch 'main' into add-plot-alias-M
yvonnefroehlich Apr 9, 2026
f1dddcd
Use underscore in alias name
yvonnefroehlich Apr 9, 2026
685603a
Merge branch 'main' into add-plot-alias-M
yvonnefroehlich Apr 10, 2026
e05991c
Change alias for M of plot to 'fill_between'
yvonnefroehlich Apr 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions pygmt/src/plot.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@
I="intensity",
L="close",
N="no_clip",
M="fill_between",
Copy link
Copy Markdown
Member Author

@yvonnefroehlich yvonnefroehlich Apr 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am sorry, but it should be between_fill to be consistent with the renaming and the other parameter names.

Copy link
Copy Markdown
Member

@seisman seisman Apr 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, I think it should be fill_between, which is more consistent with matplotlib's fill_between method (https://matplotlib.org/stable/api/_as_gen/matplotlib.pyplot.fill_between.html)

Copy link
Copy Markdown
Member Author

@yvonnefroehlich yvonnefroehlich Apr 10, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm. For Figure.wiggle, we have positive_fill and negative_fill.

What do the others think here @GenericMappingTools/pygmt-maintainers?

S="style",
W="pen",
Z="zvalue",
Expand Down Expand Up @@ -178,6 +179,10 @@ def plot( # noqa: PLR0912, PLR0913
$fill
*fill* can be a 1-D array, but it is only valid if using ``x``/``y``
and ``cmap=True`` is also required.
fill_between : str
[**c**\|\ **s**][**+l**\ *seclabel*][**+g**\ *fill*][**p**\ *pen*]
[**+r**\ *pen*][**+y**\ [*level*]].
Fill the middle area between two curves :math:`y_0(x)` and :math:`y_1(x)`.
intensity : float, bool, or 1-D array
Provide an *intensity* value (nominally in the -1 to +1 range) to
modulate the fill color by simulating illumination. If using
Expand Down
Loading