Figure.plot: Add alias "fill_between" for option -M#3169
Conversation
|
/format |
|
/format |
|
This reminds me the |
You are probably right, and a high-level method would be more user-friendly and more Pythonic. Despite this, should I still continue working on adding an alias for M or should we close this PR and the PR for the related gallery example? |
Personally I prefer to have v0.12.0 released soon and then focus on improving |
I agree that we should focus to get v0.12.0 out soon (even if I can not state how much I can help out in the next time). |
| I="intensity", | ||
| L="close", | ||
| N="no_clip", | ||
| M="fill_between", |
There was a problem hiding this comment.
I am sorry, but it should be between_fill to be consistent with the renaming and the other parameter names.
There was a problem hiding this comment.
Actually, I think it should be fill_between, which is more consistent with matplotlib's fill_between method (https://matplotlib.org/stable/api/_as_gen/matplotlib.pyplot.fill_between.html)
There was a problem hiding this comment.
Hmm. For Figure.wiggle, we have positive_fill and negative_fill.
What do the others think here @GenericMappingTools/pygmt-maintainers?
Description of proposed changes
This PR aims to add an alias for M of
plot(new in GMT 6.5.0).Sofar I use
fillcurves. But @GenericMappingTools/gmt-maintainers feel free to make suggestions for another / a better alias 🙂. Edit: changed tofill_between.Reminders
make formatandmake checkto make sure the code follows the style guide.doc/api/index.rst.Slash Commands
You can write slash commands (
/command) in the first line of a comment to performspecific operations. Supported slash command is:
/format: automatically format and lint the code