Skip to content

Safer varhandle check (part of #752 fix) #756

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cowtowncoder merged 2 commits into from
Aug 22, 2026
+14 −1
Merged

Safer varhandle check (part of #752 fix) #756

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0943b24
safer varhandle check
pjfanning Aug 21, 2026
6dab0ea
Merge branch '3.x' into cbor-check
cowtowncoder Aug 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion cbor/src/main/java/tools/jackson/dataformat/cbor/CBORGenerator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,20 @@ public class CBORGenerator extends GeneratorBase
// Whether VarHandles are available on this runtime; checked once at class load.
//
// @since 3.3
private static final boolean _VARHANDLE_AVAILABLE = CBORVarHandleUtil.isAvailable();
private static final boolean _VARHANDLE_AVAILABLE = _checkVarHandleAvailable();

private static boolean _checkVarHandleAvailable() {
// NOTE: this call is what first loads `CBORVarHandleUtil`, and that class
// names `VarHandle` in its field/method signatures. On a runtime without
// `java.lang.invoke.VarHandle` (some Android builds) loading it raises
// `NoClassDefFoundError` -- an Error, not an Exception -- so `Throwable`
// is what has to be caught here.
try {
return CBORVarHandleUtil.isAvailable();
} catch (Throwable t) {
return false;
}
}

/*
/**********************************************************************
Expand Down