Safer varhandle check (part of #752 fix) - #756
Merged
Merged
Conversation
🧪 Code Coverage Report
|
Merged
cowtowncoder
approved these changes
Aug 22, 2026
Member
|
@pjfanning I wish it was easier to test to know for sure... but just to be safe this seems reasonable. Will do one pass with CC first but will likely merge. EDIT: claude code review confirms likelihood of hard failure & soundness of fix. Will merge. |
cowtowncoder
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Android, VarHandle class is not available. The CBORVarHandleUtil class is likely not load at all because of the import.
This PR adds a try/catch in the calling code so it can live with CBORVarHandleUtil not being loaded.
Relates to #752
fyi @cowtowncoder