Mypy check on non-isolated install#4216
Merged
Merged
Conversation
schnellerhase
commented
May 15, 2026
Co-authored-by: Paul T. Kühner <56360279+schnellerhase@users.noreply.github.com>
schnellerhase
changed the title
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| - name: Run mypy | ||
| working-directory: python | ||
| run: | | ||
| pip install mypy types-cffi scipy-stubs |
| - name: Run mypy | ||
| working-directory: python | ||
| run: | | ||
| pip install mypy types-cffi scipy-stubs |
jorgensd
approved these changes
May 15, 2026
Member
jorgensd
left a comment
jorgensd
left a comment
There was a problem hiding this comment.
I'm fine with this. Its a shame that we can't separate typing from a full-blown installation.
Contributor
Author
|
Agreed, it would maybe make sense to move these install dependant linting checks outside of the general CI into an independent job. But that's something for the CI redesign if at all. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds mypy check to run on full fledged (non-PETSc) install. This allows dependency lookups and runtime awareness which enriches coverage of the
mypyinvocation.This was previously done in the BASIx CI already, which caught in multiple occasions more strict typing errors https://github.com/FEniCS/basix/blob/main/.github/workflows/dolfinx-tests.yml#L86.
This should be extended to also check the
test/anddemo/source trees (and alter to the PETSc aware runs), to follow in another PR as this hot-fixes the BASIx CI.Ref #4059 (comment), accompanies FEniCS/basix#1004.