Fix: remove PETSc stub for tmp. typing fix#1004
Merged
Merged
Conversation
schnellerhase
changed the title
schnellerhase
force-pushed
the
schnellerhase/mypy-workaround
branch
from
8a0ea70 to
1e814b7
Compare
schnellerhase
force-pushed
the
schnellerhase/mypy-workaround
branch
from
1e814b7 to
0b890de
Compare
schnellerhase
commented
May 15, 2026
Member
|
Do we need to open a housekeeping issue to remind us to remove this later, or is it covered by FEniCS/dolfinx#4059? |
Contributor
Author
|
Good idea, tracked there. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pulls in workaround from fenics-dolfiny/dolfiny@a33092c for dolfinx not having caught up with new PETSc stubs.
(The underlying issue why this is not a problem in doflinx is that this runs the mypy check without venv on a full blown PETSc aware install - dolfinx is currently missing this)
Ref FEniCS/dolfinx#4059 (comment).
Depends on FEniCS/dolfinx#4216.
(To make PETSc aware typing checks work here, we need FEniCS/dolfinx#4095)