Add better error handling for locate_dofs_topological

[jorgensd]

Resolves #4010

[schnellerhase]

Personally would prefer std::ranges::any_of. Maybe good to think about how we deal with input checks in general at some later point. Ref #4053.

[jhale]

There are a few notoriously 'easy to get wrong' functions, and this is one of them.

On the broader discussion, there are a number of things that could be done:

1. For cheap checks, we could consider a cheap 'hardening mode', e.g. https://libcxx.llvm.org/Hardening.html. And the same for expensive checks, an expensive 'hardening mode'. Users and distributors could then pick the mode they fancy. There should probably be some policy here on the complexity of the check and which category it fits in.
2. Packages in the latest distributions built against C++ standard libraries now have their cheap hardening checks enabled by default https://best.openssf.org/Compiler-Hardening-Guides/Compiler-Options-Hardening-Guide-for-C-and-C++.html. These errors don't have nice messages, but at least you get an error and termination. This PR looks like a manual check for valid-element-access policy in https://libcxx.llvm.org/Hardening.html.
3. Bit embarrassing that this isn't done but we still need to convert all of our throws to a dolfinx::runtime_error - it's bad design for callers to have to catch std::runtime_error.

[jhale]

The other option would be to have two modes; a hardened mode where we put in any check we feel necessary, regardless of complexity, and an unhardened mode.