[No QA] [Test] Pin react-native-onyx to #802 — eslint-config-expensify 4.0.8 - #95893
Draft
roryabraham wants to merge 6 commits into
Draft
[No QA] [Test] Pin react-native-onyx to #802 — eslint-config-expensify 4.0.8#95893roryabraham wants to merge 6 commits into
roryabraham wants to merge 6 commits into
Conversation
Co-authored-by: Cursor <cursoragent@cursor.com>
Pins the backward-compat fix for sourceValue and waitForCollectionCallback. Co-authored-by: Cursor <cursoragent@cursor.com>
This reverts commit a94256a.
…config-expensify-4 # Conflicts: # package-lock.json # package.json
roryabraham
changed the title
Onyx.clear() empties ReportUtils allPersonalDetails. Report holders were falling back to emails instead of display names.
49 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
Companion / verification PR for react-native-onyx PR #802. It pins
react-native-onyxto that PR's HEAD viagit+httpsso E/App CI exercises the eslint-config-expensify 4.0.8 upgrade before the Onyx PR merges and publishes.Pin:
"react-native-onyx": "git+https://github.com/Expensify/react-native-onyx.git#0a4c31dbe0e143e1138f3eb469aaac218ddba2d9".The stale
react-native-onyx+3.0.98+001+batch-collection-member-removalsApp patch is removed because this SHA already includes Onyx PR #820 (released in 3.0.100).Not for merge as-is: once Onyx PR #802 merges and publishes, repin to the released version (e.g.
"react-native-onyx": "3.0.xx") — at which point this becomes the bump PR.Fixed Issues
$
PROPOSAL:
Tests
This is a library-only bump with no user-facing UI change; the goal is to confirm no regressions in normal Onyx read/write behavior via E/App CI.
npm installandnpm run web.Offline tests
QA Steps
Same as tests. No user-facing behavior changes; this is an Onyx library bump for CI verification.