Add Card Admin workspace access#92740
Conversation
|
Hey, I noticed you changed If you want to automatically generate translations for other locales, an Expensify employee will have to:
Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running: npx ts-node ./scripts/generateTranslations.ts --helpTypically, you'd want to translate only what you changed by running |
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3570a29fa7
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9a172d17cd
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
trjExpensify
left a comment
There was a problem hiding this comment.
Core PR for a WN project. 👍
|
🚧 @flodnv has triggered a test Expensify/App build. You can view the workflow run here. |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel! Card admin can click Learn more on Get the Expensify Card banner which enables Expensify CardVersion Number: 9.4.6-0 PR:92740 Action Performed:Precondition:
Expected Result:Card admin should not be allowed to click Learn more on Get the Expensify Card banner because it will enable Expensify Card Actual Result:Card admin can click Learn more on Get the Expensify Card banner. Expensify Card tab appears and disappears after navigating away Workaround:Unknown Platforms:Which of our officially supported platforms is this issue occurring on?
Screenshots/VideosBug7179101_1781282585925.1.mp4Upwork Automation - Do Not Edit |
|
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel! Expensify Card - Error after renaming card, changing limit and limit type as card adminVersion Number: 9.4.6-0 PR:92740 Action Performed:Precondition:
Expected Result:Name will be saved without issue Actual Result:Error shows up after editing card name as card admin Workaround:Unknown Platforms:Which of our officially supported platforms is this issue occurring on?
Screenshots/VideosBug7179115_1781283536099.2.mp4Upwork Automation - Do Not Edit |
|
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel! Expensify Card - Edit spend rule opens not here page for card admin when Rules are disabledVersion Number: 9.4.6-0 PR:92740 Action Performed:Precondition:
Expected Result:Edit spend rules should be disabled for card admin when Rules are disabled Actual Result:Edit spend rules is not disabled for card admin when Rules are disabled Workaround:Unknown Platforms:Which of our officially supported platforms is this issue occurring on?
Screenshots/VideosBug7179132_1781284433513.3.mp4Upwork Automation - Do Not Edit |
|
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel! Not here page opens when card admin invites user to workspace when issuing cardVersion Number: 9.4.6-0 PR:92740 Action Performed:Precondition:
Expected Result:Card admin should be shown a better message that they cannot invite member to the workspace when issuing card Actual Result:Not here page opens when card admin invites user to workspace when issuing card Workaround:Unknown Platforms:Which of our officially supported platforms is this issue occurring on?
Screenshots/VideosBug7179154_1781285779553.4.mp4Upwork Automation - Do Not Edit |
|
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel! Company cards - Add card RHP loads infinitely after card admin finishes Plaid flowVersion Number: 9.4.6-0 PR:92740 Action Performed:Precondition:
Expected Result:Direct feed will be added successfully by card admin Actual Result:dd card RHP loads infinitely after card admin finishes Plaid flow Workaround:Unknown Platforms:Which of our officially supported platforms is this issue occurring on?
Screenshots/VideosBug7179162_1781286199144.5.mp4Upwork Automation - Do Not Edit |
|
🚀 Deployed to staging by https://github.com/flodnv in version: 9.4.7-0 🚀
Bundle Size Analysis (Sentry): |
Help site changes required ✅This PR adds a user-facing Card Admin workspace role and renames Admin → Workspace Admin in the member role surfaces, so the help site needs updating. The affected article is Draft PR: #93481 Changes made there:
Labels match @ShridharGoel, please review the linked help site PR and confirm it reflects the current behavior. Then mark the linked help site PR |
|
Opened #93478
|
|
Deploy Blocker #93500 was identified to be related to this PR. |
|
Deploy Blocker #93501 was identified to be related to this PR. |
|
Deploy Blocker #93506 was identified to be related to this PR. |
|
Deploy Blocker #93508 was identified to be related to this PR. |
|
Deploy Blocker #93509 was identified to be related to this PR. |

Explanation of Change
This adds frontend support for the Card Admin scoped workspace role.
Card Admins can access Overview, Members, Expensify Card, and Company Cards. Expensify Card and Company Cards use write-level feature checks so Card Admins can manage cards in those areas, while other workspace settings remain blocked.
This also adds Card Admin labels in member role surfaces, updates role display copy for workspace change logs, and updates imported-member role handling.
Fixed Issues
$ #90499, #90500, #90501
PROPOSAL:
Tests
Offline tests
QA Steps
Same as tests.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
Screen.Recording.2026-06-05.at.11.48.50.AM.mov