Add plain train.sbatch and best_train.sbatch launchers#523
Open
eugenevinitsky wants to merge 2 commits into
Open
Add plain train.sbatch and best_train.sbatch launchers#523eugenevinitsky wants to merge 2 commits into
eugenevinitsky wants to merge 2 commits into
Conversation
Provide a copy-pasteable single-GPU submission path next to the submitit pipeline: TRAIN_CMD uses the exact puffer CLI dash-flag format, the job log records hostname/date/commit/command, and an optional singularity wrap covers NYU Greene (cwd-safe, %q-quoted). best_train.sbatch mirrors scripts/cluster_configs/nightly_best.yaml. Document both in docs/cluster_training.md, including the one-time mkdir -p slurm_logs slurmd needs before the first submit, and gitignore slurm_logs/. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds a copy-pasteable single-GPU cluster path alongside the submitit pipeline:
scripts/train.sbatch— plain default training job (1 GPU, 16 CPU, 96 GB, 48 h).TRAIN_CMDis a bash array in the exactpuffer trainCLI dash-flag format, so it copy-pastes to and from a console command.scripts/best_train.sbatch— same skeleton (192 GB, 30 h) carrying the best-known hyperparameters translated fromscripts/cluster_configs/nightly_best.yaml, one flag per line with the yaml's section comments preserved.SINGULARITY_IMAGE+SINGULARITY_OVERLAYare set (required on NYU Greene). The wrapcds into the repo before sourcing the venv and%q-quotes every argument so the command survives thebash -cround-trip.docs/cluster_training.mdgains a short "Simple path — plain sbatch" section and a pointer from thesubmit_cluster.pysection. The submit snippet includes the one-timemkdir -p slurm_logs— slurmd opens the stdout file before the job script runs, so the directory must exist at submit time.slurm_logs/added to.gitignore.AGENTIC_PRpoem per repo convention.Why
The only documented cluster path was the ~500-line submitit pipeline, whose yaml/underscore and sweep-override formats can't be copy-pasted to or from the real
puffer trainCLI, and whose launched args end up buried in submitit stdout. These two files give a plain sbatch default where the exact command and code version are greppable from the job log.Notes
Verification performed
bash -non both scripts.TRAIN_CMDflag sets parsed throughpufferlib.pufferl.load_config(pufferlib resolved in-worktree) with zero unrecognized arguments; spot values matchnightly_best.yaml(num_agents=4096, backbone_num_layers=3, total_timesteps=10B, reward_conditioning=False, num_goals=3).singularityandSEED="1 2": payload arrives cwd-first, venv-sourced, with whitespace-containing args intact (--train.seed 1\ 2).pufferand fake venv: full launch record echoed, command invoked verbatim, exit 0.Risks
best_train.sbatchduplicatesnightly_best.yamlvalues by design ("keep in sync" header); drift is possible until one becomes canonical.submit_cluster.pywhen isolation, sweeps, DDP, or the Greene heartbeat is needed.date -Isin the launch record requires GNU date (fine on Linux clusters; fails harmlessly on macOS).Merge-order dependencies
--eval.*flags: the sibling PRfix/drive-ini-remove-hardcoded-scratch-pathsremoves/disables the[eval.behaviors_*]/[eval.validation_replay]drive.ini sections, and such flags would become unrecognized. This PR is safe to merge before or after it.docs/cluster_training.md(~lines 8–13 pre-change); this PR only inserts a new section above it and one pointer sentence at thesubmit_cluster.pyheading, so conflicts should be trivial.🤖 Generated with Claude Code
🤖 Generated with Claude Code