Pin smoke Dockerfile to amd64; fail fast on missing overlay template#521
Open
eugenevinitsky wants to merge 2 commits into
Open
Pin smoke Dockerfile to amd64; fail fast on missing overlay template#521eugenevinitsky wants to merge 2 commits into
eugenevinitsky wants to merge 2 commits into
Conversation
The smoke image is x86-64-only (bit-exact AVX2 golden, qemu-x86_64-static, amd64-only raylib archive in setup.py) but had no platform pin, so builds on Apple Silicon produced arm64 images that fail at link time. Pin FROM to linux/amd64 and document the constraint in the header comment. setup_container.sh create-overlay blindly cp'd the NYU-Greene-only OVERLAY_TEMPLATE default under set -e, giving a bare "No such file or directory" elsewhere. Add a fail-fast guard that names the path and points at OVERLAY_TEMPLATE / apptainer overlay create. Document the NYU-only defaults in README.md and docs/cluster_training.md. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
tests/smoke_tests/Dockerfile: pinFROM --platform=linux/amd64 python:3.11-slim-bookwormand extend the header comment to state that the image is x86-64-only by definition (bit-exact AVX2 golden underqemu-x86_64-static;setup.pyships only the amd64 raylib archive) and that ARM hosts run it under emulation — pass--platform linux/amd64todocker build/runif the FROM pin is not honored.scripts/setup_container.sh: increate_overlay(), add a fail-fast guard before thecp— if$OVERLAY_TEMPLATEdoes not exist, print a clear error explaining the default path exists only on NYU Greene, with two remediations (exportOVERLAY_TEMPLATE, orapptainer overlay create --size 15360 --create-dir /ext3 "$OVERLAY_PATH", available assingularity overlay createon singularity >= 3.8), thenexit 1.README.md: document that the/share/appsdefaults (IMAGE_PATH,OVERLAY_TEMPLATE) are NYU-Greene-only, thatOVERLAY_TEMPLATEis just a gzipped empty ext3 image, and how to substitute a site template /apptainer overlay create/ any CUDA-capable.sif.docs/cluster_training.md: one short comment in the quick-overview block pointing non-NYU users atOVERLAY_TEMPLATE/IMAGE_PATHexports orapptainer overlay create(see README defaults table).AGENTIC_PR: French poem per repo convention for agent-created PRs.Why
The smoke image is x86-64-only by design, but without a platform pin Apple-Silicon Docker builds an arm64 image that fails at link time (raylib 5.5 has no linux_arm64 asset). Separately,
create_overlay()blindlycp'd the NYU-Greene-only template underset -e, so everyone off Greene got a bare "No such file or directory" with no hint of what the template is or how to substitute it.Notes
bash -n scripts/setup_container.shpasses. The guard was exercised for real (safe off-cluster: onlymkdir -pon a scratchpad-scopedCONTAINER_DIRprecedes it): withOVERLAY_TEMPLATE=/nonexistent/...the script prints the full remediation message and exits 1.git diffconfirms the Dockerfile's only functional change is theFROMplatform pin;docker buildwas not run (Docker unavailable in this environment).docs/cluster_training.mdhunk was kept to a 2-line comment insertion because another PR adds a section near the top of that file; if that PR lands first, this one may need a trivial rebase (comment placement only).🤖 Generated with Claude Code
🤖 Generated with Claude Code