Support Franka in atomic-action tutorials - #519
Open
yuecideng wants to merge 2 commits into
Open
Conversation
Add selectable UR5 and Franka constructions with a shared PGI gripper across the atomic-action tutorials. Use cuRobo motion generation and generalize dual-arm setup while preserving UR5 defaults.
Greptile SummaryThe PR generalizes atomic-action tutorials to select UR5 or Franka robots and migrates tutorial motion generation to cuRobo.
Confidence Score: 4/5The PR is not yet safe to merge because migrated tutorials still fail during cuRobo initialization on hosts without CUDA. The previously reported failure remains: tutorial construction always selects CuroboPlannerCfg, whose initialization raises when CUDA is unavailable, so affected tutorials exit before compiling their actions. Files Needing Attention: scripts/tutorials/atomic_action/tutorial_utils.py
|
| Filename | Overview |
|---|---|
| scripts/tutorials/atomic_action/tutorial_utils.py | Adds robot-selection helpers and a shared cuRobo generator, but the generator still terminates tutorial startup on systems without CUDA. |
| scripts/tutorials/atomic_action/scenario_utils.py | Adds generalized dual-arm UR5/Franka configuration, mounting, solver, and gripper assembly helpers. |
| embodichain/lab/sim/planners/curobo/curobo_planner.py | Reuses centralized rigid-object naming while retaining cuRobo’s explicit CUDA availability requirement. |
| tests/sim/atomic_actions/test_tutorial_utils.py | Adds focused coverage for robot selection, tutorial imports, PGI bindings, and single- and dual-arm configuration. |
Reviews (2): Last reviewed commit: "fix(tests): update success mask argument" | Re-trigger Greptile
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds selectable UR5 and Franka constructions across the atomic-action tutorials while preserving UR5 as the default. Franka uses the same DH_PGI_140_80 gripper contract as UR5, and tutorial motion generation now uses the cuRobo backend.
It also generalizes dual-arm assembly, initial orientation, solver-root lookup, and robot-independent waypoint construction, and adds focused coverage for single- and dual-arm configurations, CLI selection, PGI bindings, and cuRobo setup.
Dependencies: None. The separate DexSim contact/rest-offset transition fix is intentionally outside this PR.
Issue: N/A (no linked issue).
Type of change
Screenshots
Not applicable.
Validation
black --check --diff --color ./— 665 files unchanged in a clean worktreepytest -q tests/sim/atomic_actions/test_tutorial_utils.py tests/sim/planners/test_curobo_planner.py tests/sim/planners/test_curobo_integration.py— 89 passed, 1 skipped, 6 deselectedpython scripts/tutorials/atomic_action/coordinated_pickment.py --robot franka --viser— exited successfully with no PhysX contact/rest-offset warningspython scripts/tutorials/atomic_action/coordinated_pickment.py --viser— exited successfullypython scripts/tutorials/atomic_action/coordinated_placement.py --viser— exited successfullyChecklist
black .command to format the code base.