Fix observation space issue for BaseEnv #125
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuecideng
added
bug
There was a problem hiding this comment.
Pull request overview
This PR aims to fix BaseEnv observation space creation when initial observations are torch tensors by adding automatic conversion from torch.Tensor to gymnasium.spaces.Box.
Changes:
- Add
torch.Tensorhandling toconvert_observation_to_space()to infershape,dtype, and bounds. - Introduce torch→NumPy dtype mapping logic for Box space construction.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add support for automatic obs space conversion from torch tensor.
Type of change
Checklist
black .command to format the code base.