Skip to content

perf(evm): precheck linear MSTORE8 memory writes #552

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ECNUyhy wants to merge 2 commits into
base: main
Choose a base branch
from
Open

perf(evm): precheck linear MSTORE8 memory writes #552

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fe891ec
perf(evm): precheck linear MSTORE8 memory writes
ECNUyhy Jun 27, 2026
d469173
style(evm): format MSTORE8 precheck visitor
ECNUyhy Jun 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
49 changes: 48 additions & 1 deletion src/action/evm_bytecode_visitor.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -601,6 +601,7 @@ template <typename IRBuilder> class EVMByteCodeVisitor {

case OP_MSTORE8: {
Builder.noteMemoryOpcodeInBlock(Opcode, PC);
maybePrepareLinearBlockMemoryPrecheck(Opcode);
Operand Addr = pop();
Operand Value = pop();
Builder.handleMStore8(Addr, Value);
Expand Down Expand Up @@ -1337,15 +1338,61 @@ template <typename IRBuilder> class EVMByteCodeVisitor {
return Plan;
}

BlockLinearPrecheckPlan analyzeLinearMstore8DirectMemoryBlockPrecheck(
const Byte *Bytecode, size_t BytecodeSize, uint64_t EntryPC) {
uint64_t ScanPC = 0;
if (!consumeLinearRecurrencePrefix(Bytecode, BytecodeSize, EntryPC,
ScanPC)) {
return {};
}

uint64_t CoveredDirectOps = 0;
while (ScanPC < BytecodeSize) {
evmc_opcode Opcode = static_cast<evmc_opcode>(Bytecode[ScanPC]);
if (Opcode == OP_JUMPDEST || isBlockTerminatorOpcode(Opcode)) {
break;
}

uint64_t MotifPC = ScanPC;
if (!consumeExpectedOpcode(Bytecode, BytecodeSize, MotifPC, OP_DUP1) ||
!consumeExpectedOpcode(Bytecode, BytecodeSize, MotifPC, OP_DUP1) ||
!consumeExpectedOpcode(Bytecode, BytecodeSize, MotifPC, OP_MSTORE8) ||
!consumeExpectedOpcode(Bytecode, BytecodeSize, MotifPC, OP_DUP2) ||
!consumeExpectedOpcode(Bytecode, BytecodeSize, MotifPC, OP_ADD)) {
return {};
}

++CoveredDirectOps;
ScanPC = MotifPC;
}

if (CoveredDirectOps < 2) {
return {};
}

BlockLinearPrecheckPlan Plan;
Plan.Eligible = true;
Plan.CoveredOpcode = OP_MSTORE8;
Plan.AccessWidth = 1;
Plan.CoveredDirectOps = CoveredDirectOps;
Plan.StrideStackIndex = 3;
return Plan;
}

BlockLinearPrecheckPlan analyzeLinearDirectMemoryBlockPrecheck(
const Byte *Bytecode, size_t BytecodeSize, uint64_t EntryPC) {
BlockLinearPrecheckPlan Plan = analyzeLinearMloadDirectMemoryBlockPrecheck(
Bytecode, BytecodeSize, EntryPC);
if (Plan.Eligible) {
return Plan;
}
return analyzeLinearMstoreDirectMemoryBlockPrecheck(Bytecode, BytecodeSize,
Plan = analyzeLinearMstoreDirectMemoryBlockPrecheck(Bytecode, BytecodeSize,
EntryPC);
if (Plan.Eligible) {
return Plan;
}
return analyzeLinearMstore8DirectMemoryBlockPrecheck(Bytecode, BytecodeSize,
EntryPC);
}

void maybePrepareLinearBlockMemoryPrecheck(evmc_opcode Opcode) {
Expand Down
22 changes: 17 additions & 5 deletions src/compiler/evm_frontend/evm_mir_compiler.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4967,18 +4967,29 @@ void EVMMirBuilder::handleMStore8(Operand AddrComponents,
const bool OffsetWasConst = AddrComponents.isConstU64();
const uint64_t OriginalConstOffset =
OffsetWasConst ? AddrComponents.getConstValue()[0] : 0;
const bool OffsetKnownU64 = OffsetWasConst;
bool OffsetKnownU64 = OffsetWasConst;
const bool CanUseConstBaseDispPath =
OffsetWasConst &&
(ConstAddr = OriginalConstOffset) <= static_cast<uint64_t>(INT32_MAX);
normalizeOperandU64(AddrComponents);
#ifdef ZEN_ENABLE_EVM_GAS_REGISTER
syncGasToMemory();
#endif
MType *I64Type = &Ctx.I64Type;

U256Inst AddrParts = extractU256Operand(AddrComponents);
MInstruction *Offset = AddrParts[0];
const bool CanUseLinearU64AddrFastPath =
CurBlockLinearPrecheckPlan.Active &&
CurBlockLinearPrecheckPlan.CoveredDirectOpsRemaining != 0;
MInstruction *Offset = nullptr;
bool UsedLinearPrecheck = false;
if (CanUseLinearU64AddrFastPath) {
Offset = extractKnownU64LowOperand(AddrComponents);
UsedLinearPrecheck = tryConsumeLinearBlockMemoryPrecheck(Offset, nullptr);
OffsetKnownU64 = OffsetKnownU64 || UsedLinearPrecheck;
}
if (!UsedLinearPrecheck) {
normalizeOperandU64(AddrComponents);
Offset = extractKnownU64LowOperand(AddrComponents);
}
U256Inst ValueParts = extractU256Operand(ValueComponents);

MInstruction *SizeConst = createIntConstInstruction(I64Type, 1);
Expand All @@ -4993,7 +5004,8 @@ void EVMMirBuilder::handleMStore8(Operand AddrComponents,
MInstruction *Overflow = createInstruction<CmpInstruction>(
false, CmpInstruction::Predicate::ICMP_ULT, I64Type, RequiredSize,
Offset);
bool UsedSharedPrecheck = tryConsumeConstBlockMemoryPrecheck();
bool UsedSharedPrecheck =
UsedLinearPrecheck || tryConsumeConstBlockMemoryPrecheck();
noteSmallFrameMemoryOp(SmallFrameMemoryOp::MStore8, OffsetWasConst,
OriginalConstOffset, OffsetKnownU64, 1,
UsedSharedPrecheck);
Expand Down
74 changes: 72 additions & 2 deletions src/tests/evm_jit_frontend_tests.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -386,8 +386,17 @@ class MockEVMBuilder {

void beginMemoryCompileBlock(uint64_t) {}
void setMemoryCompileBlockConstPrecheckPlan(uint64_t, uint64_t) {}
void setMemoryCompileBlockLinearPrecheckPlan(uint64_t, uint64_t, bool) {}
void prepareLinearBlockMemoryPrecheck(Operand) {}
void setMemoryCompileBlockLinearPrecheckPlan(uint64_t AccessWidth,
uint64_t CoveredDirectOps,
bool ValueEqualsFirstAddr) {
LinearPrecheckPlanCount++;
LastLinearPrecheckAccessWidth = AccessWidth;
LastLinearPrecheckCoveredDirectOps = CoveredDirectOps;
LastLinearPrecheckValueEqualsFirstAddr = ValueEqualsFirstAddr;
}
void prepareLinearBlockMemoryPrecheck(Operand) {
LinearPrecheckPrepareCount++;
}
void noteMemoryOpcodeInBlock(evmc_opcode, uint64_t) {}
void noteHelperOpcodeInBlock(evmc_opcode, uint64_t) {}
void endMemoryCompileBlock() {}
Expand Down Expand Up @@ -455,6 +464,24 @@ class MockEVMBuilder {
return RuntimeStack.back().resolvedValue();
}

uint32_t linearPrecheckPlanCount() const { return LinearPrecheckPlanCount; }

uint64_t lastLinearPrecheckAccessWidth() const {
return LastLinearPrecheckAccessWidth;
}

uint64_t lastLinearPrecheckCoveredDirectOps() const {
return LastLinearPrecheckCoveredDirectOps;
}

bool lastLinearPrecheckValueEqualsFirstAddr() const {
return LastLinearPrecheckValueEqualsFirstAddr;
}

uint32_t linearPrecheckPrepareCount() const {
return LinearPrecheckPrepareCount;
}

bool Trapped = false;
bool Undefined = false;

Expand All @@ -478,6 +505,11 @@ class MockEVMBuilder {
std::vector<Operand> RuntimeStack;
MockOperand::U256Value LastPushValue = {0, 0, 0, 0};
bool HasLastPushValue = false;
uint32_t LinearPrecheckPlanCount = 0;
uint64_t LastLinearPrecheckAccessWidth = 0;
uint64_t LastLinearPrecheckCoveredDirectOps = 0;
bool LastLinearPrecheckValueEqualsFirstAddr = false;
uint32_t LinearPrecheckPrepareCount = 0;

#undef MOCK_OPERAND_STUB
#undef MOCK_VOID_STUB
Expand Down Expand Up @@ -1140,6 +1172,44 @@ TEST(EVMJITFrontendVisitorTest, FusesLinearMStoreNextMotifIntoMeteredRange) {
EXPECT_EQ(Builder.topStackValue()[0], 0x60U);
}

TEST(EVMJITFrontendVisitorTest, PlansLinearMStore8NextMotifMemoryPrecheck) {
const std::vector<uint8_t> Bytecode = {
0x5f, // PUSH0 calldata offset for stride
0x35, // CALLDATALOAD
0x5f, // PUSH0 current
0x80, // DUP1
0x80, // DUP1
0x53, // MSTORE8
0x81, // DUP2
0x01, // ADD
0x80, // DUP1
0x80, // DUP1
0x53, // MSTORE8
0x81, // DUP2
0x01, // ADD
0x00 // STOP
};

COMPILER::EVMFrontendContext Ctx;
Ctx.setRevision(EVMC_CANCUN);
Ctx.setBytecode(reinterpret_cast<const zen::common::Byte *>(Bytecode.data()),
Bytecode.size());

MockEVMBuilder Builder;
COMPILER::EVMByteCodeVisitor<MockEVMBuilder> Visitor(Builder, &Ctx);
EXPECT_TRUE(Visitor.compile());
EXPECT_FALSE(Builder.Trapped);
EXPECT_FALSE(Builder.Undefined);

EXPECT_EQ(Builder.linearPrecheckPlanCount(), 1U);
EXPECT_EQ(Builder.lastLinearPrecheckAccessWidth(), 1U);
EXPECT_EQ(Builder.lastLinearPrecheckCoveredDirectOps(), 2U);
EXPECT_FALSE(Builder.lastLinearPrecheckValueEqualsFirstAddr());
EXPECT_EQ(Builder.linearPrecheckPrepareCount(), 2U);
EXPECT_EQ(Builder.meteredOpcodeCount(OP_MSTORE8), 2U);
EXPECT_EQ(Builder.runtimeStackDepth(), 2U);
}

TEST(EVMJITFrontendVisitorTest, FusesCallerSlotKeccakIntoMeteredRange) {
const std::vector<uint8_t> Bytecode = {
0x33, // CALLER
Expand Down
Loading