perf(evm): precheck linear MSTORE8 memory writes#552
Open
ECNUyhy wants to merge 2 commits into
Open
Conversation
Extend the EVM JIT linear memory precheck planner to cover repeated MSTORE8 write motifs. Reuse the existing block precheck plan with AccessWidth=1 so byte writes can share one memory proof across the block. Previously, dynamic MSTORE8 recurrences still normalized and prechecked memory per opcode while MLOAD and MSTORE could consume a shared linear block precheck.
⚡ Performance Regression Check Results✅ Performance Check Passed (interpreter)Performance Benchmark Results (threshold: 25%)
Summary: 194 benchmarks, 0 regressions ✅ Performance Check Passed (multipass)Performance Benchmark Results (threshold: 25%)
Summary: 194 benchmarks, 0 regressions |
Apply clang-format to the MSTORE8 linear precheck visitor condition so the CI format check accepts the PR.
4bd2a32 to
d469173
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extend the EVM JIT linear memory precheck planner to cover repeated MSTORE8 write motifs. Reuse the existing block precheck plan with AccessWidth=1 so byte writes can share one memory proof across the block.
Previously, dynamic MSTORE8 recurrences still normalized and prechecked memory per opcode while MLOAD and MSTORE could consume a shared linear block precheck.
1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):
2. What is the scope of this PR (e.g. component or file name):
3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):
4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):
5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:
6. Release note