generated from CodeYourFuture/Module-Template
-
-
Notifications
You must be signed in to change notification settings - Fork 337
West Midlands | 26-Jan-ITP | Fida H Ali Zada | Sprint 3 | TDD #1134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
alizada-dev
wants to merge
11
commits into
CodeYourFuture:main
Choose a base branch
from
alizada-dev:coursework/sprint-3-practice-tdd
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
0277b9d
Installed jest
alizada-dev f122d5d
Wrote the test
alizada-dev 1da9615
Wrote the code for count function
alizada-dev e4845c4
repeat-str.test.js completed
alizada-dev e56c42c
repeatStr function code completed
alizada-dev 7f2b357
Completed get-ordinal-number.test.js
alizada-dev 23a26c6
wrote the function getOrdinalNumber code
alizada-dev c456e28
add an error message and removed the commented code on line 48
alizada-dev babb7ac
modified countChar function so it can work for the non-alphabet test …
alizada-dev 9e13ea1
fixed a typo in the test description and made all the descriptions co…
alizada-dev c76e43f
minor changes in the test cases
alizada-dev File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,10 @@ | ||
| function countChar(stringOfCharacters, findCharacter) { | ||
| return 5 | ||
| if (findCharacter == "") return 0; | ||
|
|
||
| const string = stringOfCharacters.toLowerCase(); | ||
| const char = findCharacter.toLowerCase(); | ||
|
|
||
| return string.split(char).length - 1; | ||
| } | ||
|
|
||
| module.exports = countChar; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -22,3 +22,25 @@ test("should count multiple occurrences of a character", () => { | |
| // And a character `char` that does not exist within `str`. | ||
| // When the function is called with these inputs, | ||
| // Then it should return 0, indicating that no occurrences of `char` were found. | ||
| test(`should return 0 for no occurances of 'char' in 'str'`, () => { | ||
| const str = "code your future"; | ||
| const char = "x"; | ||
| const count = countChar(str, char); | ||
| expect(count).toEqual(0); | ||
| }) | ||
|
|
||
| test(`in case sensitive case, should also return the number of character in the string`, () => { | ||
| expect(countChar("Code Your Future!", "y")).toEqual(1); | ||
| }); | ||
|
|
||
|
Comment on lines
+32
to
+35
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Could include a lower case |
||
| test(`should return the count of character for non-alphabests`, () => { | ||
| expect(countChar("86421", "1")).toEqual(1); | ||
| }); | ||
|
|
||
| test(`should return 0 for empty strings`, () => { | ||
| expect(countChar("code your future", "")).toEqual(0) | ||
| }); | ||
|
|
||
| test(`should return the count for special characters`, () => { | ||
| expect(countChar("code& $future £your", "$")).toEqual(1) | ||
| }) | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,19 @@ | ||
| function getOrdinalNumber(num) { | ||
| return "1st"; | ||
| const lastDigit = num % 10; | ||
| const lastTwoDigits = num % 100; | ||
|
|
||
| if (lastTwoDigits === 11 || lastTwoDigits === 12 || lastTwoDigits === 13) { | ||
| return `${num}th`; | ||
| } else if (lastDigit === 1) { | ||
| return `${num}st`; | ||
| } else if (lastDigit === 2) { | ||
| return `${num}nd`; | ||
| } else if (lastDigit === 3) { | ||
| return `${num}rd`; | ||
| } else { | ||
| return `${num}th`; | ||
|
|
||
| } | ||
| } | ||
|
|
||
| module.exports = getOrdinalNumber; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could consider testing more samples.
Could consider testing these cases:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, sir, for the review. I fixed all the suggested changes.