West Midlands | 26-Jan-ITP | Fida H Ali Zada | Sprint 3 | TDD#1134
Open
alizada-dev wants to merge 7 commits intoCodeYourFuture:mainfrom
Open
West Midlands | 26-Jan-ITP | Fida H Ali Zada | Sprint 3 | TDD#1134alizada-dev wants to merge 7 commits intoCodeYourFuture:mainfrom
alizada-dev wants to merge 7 commits intoCodeYourFuture:mainfrom
Conversation
alizada-dev
added
the
Needs Review
cjyuan
reviewed
Mar 10, 2026
Comment on lines
+25
to
+30
| test(`should return 0 for no occurances of 'char' in 'str'`, () => { | ||
| const str = "code your future"; | ||
| const char = "x"; | ||
| const count = countChar(str, char); | ||
| expect(count).toEqual(0); | ||
| }) |
Contributor
There was a problem hiding this comment.
-
Could consider testing more samples.
-
Could consider testing these cases:
- A case to show that the match is case sensitive
- A case to show that the function is expected to work also for non-alphabets
| expect(getOrdinalNumber(533)).toEqual("533rd"); | ||
| }) | ||
|
|
||
| test("should append 'th' for numbers ending to any numbers expect (1, 2, 3)", () => { |
Contributor
There was a problem hiding this comment.
Typo in the description?
Could consider asking AI to see if the description could be made more concise.
| if (count >= 0) { | ||
| return str.repeat(count); | ||
| } else { | ||
| throw new Error(""); |
Contributor
There was a problem hiding this comment.
Why not include an informative error message to inform the caller what the error is?
| test("should throw an error", () => { | ||
| const str = "responsibility"; | ||
| const count = -5; | ||
| // const repeatedStr = repeatStr(str, count); |
Contributor
There was a problem hiding this comment.
Why keep the code as comment on line 48?
cjyuan
added
Reviewed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Wrote tests before the code that will make them pass.