bugfix: Improve POH detection by checking for portal#45
Open
kelltom wants to merge 1 commit intoCar-Role:masterfrom
Open
bugfix: Improve POH detection by checking for portal#45kelltom wants to merge 1 commit intoCar-Role:masterfrom
kelltom wants to merge 1 commit intoCar-Role:masterfrom
Conversation
This change stops using region IDs for POH detection. POHs are dynamically assembled instanced areas, so region IDs change and aren't reliable in the long term. Detect POHs by scanning the instance scene for the POH exit portal instead. Cache whether it has been found or not to prevent repeated scene scans for the current region.
kelltom
changed the title
Author
|
Region ID for Mount Quid no longer matches with one of our POH region ID constants, fixing #38 . java_kMn45Gqud2.mp4Works in POH. java_Ve00KF8EeN.mp4 |
Car-Role
pushed a commit
that referenced
this pull request
Mar 28, 2026
PR #43: Hunter — maniacal monkey trap detection (new feature) PR #45: POH detection — exit portal scanning (resolves #38, #26) Bug #41: Amethyst dart tips — AnimationID.GEM_CUTTING_AMETHYST (6295) added to Crafting Bug #42: Fish cutting — BRUT_HUMAN_KNIFEUSE + sacred/infernal eels added to Cooking Feature #39: Salvaging split — separate toggles for salvaging hook vs sorting salvage Feature #40: Hotkey toggle — Keybind config + HotkeyListener via KeyManager Feature #23: Activation delay — new activationDelay config in Timing section; skilling must be detected continuously for that many ticks before the overlay appears (default 0 = immediate) Feature #28: Thieving — THIEVING_ANIMATION_IDS set (pickpocketing 881, stalls 832, Varlamore houses AnimationID.THIEVING_VARLAMORE_STEALING_VALUABLES) + thieving() config toggle README: Added Firemaking, Magic, Sailing (Sorting), Thieving, fish cutting, amethyst, hotkey toggle, activation delay to features list
Owner
|
@kelltom, Thank you for all the help. I have added everything you've PR'd and will be pushing to the plugin hub soon |
Owner
|
merged, in f8894bf |
Author
|
@Car-Role My pleasure, love the plugin! Hope to contribute more soon. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change stops using region IDs for POH detection. POHs are dynamically assembled instanced areas, so region IDs change and aren't reliable in the long term. Detect POHs by scanning the instance scene for the POH exit portal instead. Cache whether it has been found or not to prevent repeated scene scans for the current region.
Resolves #38, and #26