Open
Conversation
toa detection change and added more enchantment IDs
commit: Add bonfire firemaking support and improve movement detection - Added support for adding logs to bonfires with correct animation IDs - Added firemaking toggle to config section - Improved movement detection by tracking both animation poses and position changes - Added immediate overlay clearing when movement is detected - Excluded manual tinderbox firemaking animations - Added debug logging for overlay visibility changes Animation IDs added for bonfire firemaking: - Regular logs (10565) - Oak logs (10569) - Willow logs (10572) - Maple logs (10568) - Yew logs (10573) - Magic logs (10566) - Redwood logs (10570)
Changed config option of bake pie to prevent false positives of contact NPC
added: option to show chat, inventory, and stats for the overlay fail-safes for false positives for Gauntlet/Corrupted Gauntlet, COX, Duke using Varbit 9178
updated to correct runelite constants
feat: Add combat integration with wilderness support and spell detection Major Features Added: - Combat blackout detection for specified monsters with configurable timing - Wilderness-aware combat behavior with robust area detection - String Jewelry and Plank Make spell support with safety quarantine - Enhanced configuration organization with position-based ordering Combat Integration: - Detect combat engagement using RuneLite API (getInteracting()) - Support both monster IDs and names for flexible targeting - Combat restore delay in ticks (default: 8) for precise timing - Health and prayer override thresholds using absolute values - Default monster: "Gemstone Crab" with combat blackout enabled Wilderness Support: - WorldArea-based wilderness detection (avoids instance false positives) - "Enable in Wilderness" toggle for granular PvP/PvE control - Robust detection covering above/underground wilderness areas - Default: disabled in wilderness for safety awareness Spell Detection: - String Jewelry (animation ID 4412) and Plank Make (6298) support - Quarantined in Miscellaneous section with warning labels - Default disabled due to problematic animation IDs - Conditional detection only when explicitly enabled Configuration Improvements: - Reorganized Combat section with logical positioning (1-54) - Combat Restore Delay changed from seconds to ticks - Health/Prayer thresholds grouped together for better UX - Enhanced descriptions with Identificator plugin guidance Technical Enhancements: - Enhanced debug logging for combat, wilderness, and override states - Dynamic monster list parsing with config change listeners - Comprehensive safety checks and override logic integration - Import additions for WorldArea and improved error handling
PR runelite#44: Firemaking — all log types via API constants (resolves runelite#37, runelite#34) PR runelite#43: Hunter — maniacal monkey trap detection (new feature) PR runelite#45: POH detection — exit portal scanning (resolves runelite#38, runelite#26) Bug runelite#41: Amethyst dart tips — AnimationID.GEM_CUTTING_AMETHYST (6295) added to Crafting Bug runelite#42: Fish cutting — BRUT_HUMAN_KNIFEUSE + sacred/infernal eels added to Cooking Feature runelite#39: Salvaging split — separate toggles for salvaging hook vs sorting salvage Feature runelite#40: Hotkey toggle — Keybind config + HotkeyListener via KeyManager Feature runelite#23: Activation delay — new activationDelay config in Timing section; skilling must be detected continuously for that many ticks before the overlay appears (default 0 = immediate) Feature runelite#28: Thieving — THIEVING_ANIMATION_IDS set (pickpocketing 881, stalls 832, Varlamore houses AnimationID.THIEVING_VARLAMORE_STEALING_VALUABLES) + thieving() config toggle README: Added Firemaking, Magic, Sailing (Sorting), Thieving, fish cutting, amethyst, hotkey toggle, activation delay to features list Add screenshot overlay hiding for level ups and collection log events New config toggle "Hide overlay in screenshots" (default enabled) temporarily suppresses overlay for 3 ticks when level up messages or collection log interface appears, ensuring automatic screenshots are clean
|
|
|
Internal use only: Reviewer details Maintainer details |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Car-Role/Distraction-Reducer#44: Firemaking — all log types via API constants (resolves Car-Role/Distraction-Reducer#37, Car-Role/Distraction-Reducer#34)
PR Car-Role/Distraction-Reducer#43: Hunter — maniacal monkey trap detection (new feature)
PR Car-Role/Distraction-Reducer#45: POH detection — exit portal scanning (resolves Car-Role/Distraction-Reducer#38, Car-Role/Distraction-Reducer#26)
Bug Car-Role/Distraction-Reducer#41: Amethyst dart tips — AnimationID.GEM_CUTTING_AMETHYST (6295) added to Crafting
Bug Car-Role/Distraction-Reducer#42: Fish cutting — BRUT_HUMAN_KNIFEUSE + sacred/infernal eels added to Cooking
Feature Car-Role/Distraction-Reducer#39: Salvaging split — separate toggles for salvaging hook vs sorting salvage
Feature Car-Role/Distraction-Reducer#40: Hotkey toggle — Keybind config + HotkeyListener via KeyManager
Feature Car-Role/Distraction-Reducer#23: Activation delay — new activationDelay config in Timing section; skilling must be detected continuously for that many ticks before the overlay appears (default 0 = immediate)
Feature Car-Role/Distraction-Reducer#28: Thieving — THIEVING_ANIMATION_IDS set (pickpocketing 881, stalls 832, Varlamore houses AnimationID.THIEVING_VARLAMORE_STEALING_VALUABLES) + thieving() config toggle
README: Added Firemaking, Magic, Sailing (Sorting), Thieving, fish cutting, amethyst, hotkey toggle, activation delay to features list
Add screenshot overlay hiding for level-ups and collection log events
New config toggle "Hide overlay in screenshots" (default enabled) temporarily suppresses overlay for 3 ticks when level up messages or collection log interface appears, ensuring automatic screenshots are clean