fix: address outstanding goconst linter errors on main

pkg/agent/baker.go

@@ -80,6 +80,11 @@ func (t *TemplateGenerator) getLinuxNodeCustomDataJSONObject(config *datamodel.N
 	return fmt.Sprintf("{\"customData\": \"%s\"}", str)
 }
 
+const (
+	encodingGZIP   = "gzip"
+	encodingBase64 = "base64"
+)
+
 const (
 	ignitionFilesTarPath      = "/var/lib/ignition/ignition-files.tar"
 	ignitionBootcmdScriptPath = "/etc/ignition-bootcmds.sh"
@@ -107,13 +112,13 @@ func buildIgnitionTarEntries(customData cloudInit) ([]ignitionTarEntry, error) {
 		switch {
 		case file.Content == "" || file.Encoding == "":
 			contents = []byte(file.Content)
-		case file.Encoding == "gzip":
+		case file.Encoding == encodingGZIP:
 			decoded, err := getGzipDecodedValue([]byte(file.Content))
 			if err != nil {
 				return nil, fmt.Errorf("failed to decode gzip content for %s: %w", file.Path, err)
 			}
 			contents = decoded
-		case file.Encoding == "base64":
+		case file.Encoding == encodingBase64:
 			decoded, err := base64.StdEncoding.DecodeString(file.Content)
 			if err != nil {
 				return nil, fmt.Errorf("failed to decode base64 content: %w", err)
@@ -208,7 +213,7 @@ func cloudInitToButane(customData cloudInit) flatcar1_1.Config {
 		Overwrite: to.BoolPtr(true),
 		Contents: base0_5.Resource{
 			Source:      to.StringPtr(dataURL),
-			Compression: to.StringPtr("gzip"),
+			Compression: to.StringPtr(encodingGZIP),
 		},
 	}
 	butaneconfig.Storage.Files = append(butaneconfig.Storage.Files, tarFile)

pkg/agent/baker_test.go

@@ -58,17 +58,11 @@ type nodeBootstrappingOutput struct {
 }
 
 type decodedValue struct {
-	encoding cseVariableEncoding
+	encoding string
 	value    string
 	mode     int64
 }
 
-type cseVariableEncoding string
-
-const (
-	cseVariableEncodingGzip cseVariableEncoding = "gzip"
-)
-
 type outputValidator func(*nodeBootstrappingOutput)
 
 var _ = Describe("Assert generated customData and cseCmd", func() {
@@ -2245,7 +2239,7 @@ func ignitionDecodeFileContents(input ign3_4.Resource) ([]byte, error) {
 		return nil, err
 	}
 	contents := decodeddata.Data
-	if input.Compression != nil && *input.Compression == "gzip" {
+	if input.Compression != nil && *input.Compression == encodingGZIP {
 		contents, err = getGzipDecodedValue(contents)
 		if err != nil {
 			return nil, err
@@ -2298,7 +2292,7 @@ func writeInnerCustomData(outputname, customData string) error {
 			"overwrite": true,
 			"mode":      entry.mode,
 			"contents": map[string]interface{}{
-				"compression": "gzip",
+				"compression": encodingGZIP,
 				"source":      "data:;base64," + base64.StdEncoding.EncodeToString(gzippedContents),
 			},
 		})
@@ -2384,17 +2378,17 @@ func getDecodedFilesFromCustomdata(data []byte) (map[string]*decodedValue, error
 	var files = make(map[string]*decodedValue)
 
 	for _, val := range customData.WriteFiles {
-		var encoding cseVariableEncoding
+		var encoding string
 		maybeEncodedValue := val.Content
 
-		if strings.Contains(val.Encoding, "gzip") {
+		if strings.Contains(val.Encoding, encodingGZIP) {
 			if maybeEncodedValue != "" {
 				output, err := getGzipDecodedValue([]byte(maybeEncodedValue))
 				if err != nil {
 					return nil, fmt.Errorf("failed to decode gzip value: %q with error %w", maybeEncodedValue, err)
 				}
 				maybeEncodedValue = string(output)
-				encoding = cseVariableEncodingGzip
+				encoding = encodingGZIP
 			}
 		}
 
@@ -2936,7 +2930,7 @@ var _ = Describe("cloudInitToButane", func() {
 			{
 				Path:        "/etc/test-gzip",
 				Permissions: "0644",
-				Encoding:    "gzip",
+				Encoding:    encodingGZIP,
 				Content:     string(gzipped),
 			},
 		}}
@@ -3015,7 +3009,7 @@ func decodeButaneResource(resource base0_5.Resource) ([]byte, error) {
 		return nil, err
 	}
 	contents := decodeddata.Data
-	if resource.Compression != nil && *resource.Compression == "gzip" {
+	if resource.Compression != nil && *resource.Compression == encodingGZIP {
 		contents, err = getGzipDecodedValue(contents)
 		if err != nil {
 			return nil, err