fix: address outstanding goconst linter errors on main#7950
Merged
awesomenix merged 1 commit intomainfrom Feb 25, 2026
Merged
Conversation
cameronmeissner
requested review from
AbelHu,
Devinwong,
awesomenix,
calvin197,
djsly,
ganeshkumarashok,
juan-lee,
junjiezhang1997,
lilypan26,
mxj220,
pdamianov-dev,
phealy,
r2k1,
timmy-wright and
zachary-bailey
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses golangci-lint goconst findings by deduplicating repeated encoding string literals used across the agent package’s cloud-init/ignition handling and related tests.
Changes:
- Introduces shared package-level constants for common encodings (
gzip,base64) inpkg/agent/baker.go. - Replaces repeated
"gzip"string literals withencodingGZIPin both implementation and tests. - Simplifies a test-only encoding type alias in
baker_test.goby usingstringdirectly.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| pkg/agent/baker.go | Adds encodingGZIP / encodingBase64 constants and uses them in encoding/decoding logic. |
| pkg/agent/baker_test.go | Updates tests to use encodingGZIP and removes a redundant test-local encoding type/const. |
awesomenix
approved these changes
Feb 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
addresses golang-ci-lint failures on
mainWhich issue(s) this PR fixes:
Fixes #