Skip to content

sets file format to mkv#1730

Merged
micahwoodard merged 2 commits intodevelopfrom
feat-mp4-to-mkv
Apr 2, 2026
Merged

sets file format to mkv#1730
micahwoodard merged 2 commits intodevelopfrom
feat-mp4-to-mkv

Conversation

@micahwoodard
Copy link
Copy Markdown
Collaborator

@micahwoodard micahwoodard commented Mar 24, 2026

Pull Request instructions:

  • Please follow the update protocol
  • Answer the questions below in detail. Your responses will be emailed to experimenters.
  • If the experimenters must do anything new, provide detailed step by step instructions on the wiki
  • If computer maintainers need to manually update anything, provide detailed step by step instructions
  • Use markdown syntax in order for your comments to be rendered reliably in the email: "1." instead of "1)", use four spaces for indents.
  • If you use the keyword "skip email" in the title, it will skip the email updates
  • Merges from "develop" into "production_testing" should use the keyword "production merge" in the title for reliable indexing of updates
  • Merges from "production_testing" into "main" should use the keyword "update main"

Describe changes:

  • sets default file format to mkv
  • adds video_file_format field in settings model

What issues or discussions does this update address?

Describe the expected change in behavior from the perspective of the experimenter

  • None

Describe any manual update steps for task computers

  • Add field video_file_format to csv if desired video file format is not mkv

Was this update tested in 446/447?

  • 446/7

Does this update impact downstream processing by adding new saved files, or changing their format? If so, have you documented changes?

  • No

@alexpiet
Copy link
Copy Markdown
Collaborator

@rachelstephlee

@micahwoodard micahwoodard marked this pull request as draft March 24, 2026 19:12
@micahwoodard
Copy link
Copy Markdown
Collaborator Author

Still need to test and confirm on rig

@micahwoodard micahwoodard marked this pull request as ready for review March 24, 2026 21:26
@micahwoodard
Copy link
Copy Markdown
Collaborator Author

Tested on rig both mkv and mp4 format specified in the csv settings file. Also played videos. Here is snapshot of bonsai code. This pattern is repeated at every camera.
image

@rachelstephlee
Copy link
Copy Markdown
Contributor

i'm scheduling time to test this with ella. i won't need a mouse to test it.

@micahwoodard
Copy link
Copy Markdown
Collaborator Author

@rachelstephlee did you test this? Feel free to test again but I tested it when I made the pr and confirmed that both mkv and mp4 format specified in the csv settings file wrote the correct file and then also opened and played videos to make sure nothing was corrupted. Are you planning on testing new ffmpeg args?

@rachelstephlee
Copy link
Copy Markdown
Contributor

I've asked ella for test time, but if you feel confident (it's fairly easy to check) and if there's an alternative way for me to test, I"m fine with approving.

@rachelstephlee
Copy link
Copy Markdown
Contributor

I'm just using the AIND file standard.

@micahwoodard micahwoodard merged commit d885425 into develop Apr 2, 2026
@micahwoodard micahwoodard deleted the feat-mp4-to-mkv branch April 2, 2026 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants