Merged
Conversation
Collaborator
Collaborator
Author
|
Still need to test and confirm on rig |
Collaborator
Author
Contributor
|
i'm scheduling time to test this with ella. i won't need a mouse to test it. |
Collaborator
Author
|
@rachelstephlee did you test this? Feel free to test again but I tested it when I made the pr and confirmed that both mkv and mp4 format specified in the csv settings file wrote the correct file and then also opened and played videos to make sure nothing was corrupted. Are you planning on testing new ffmpeg args? |
Contributor
|
I've asked ella for test time, but if you feel confident (it's fairly easy to check) and if there's an alternative way for me to test, I"m fine with approving. |
Contributor
|
I'm just using the AIND file standard. |
rachelstephlee
approved these changes
Apr 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Pull Request instructions:
Describe changes:
What issues or discussions does this update address?
Describe the expected change in behavior from the perspective of the experimenter
Describe any manual update steps for task computers
Was this update tested in 446/447?
Does this update impact downstream processing by adding new saved files, or changing their format? If so, have you documented changes?