Open
Conversation
…ta-streams-and-data_descriptionmodalities
saskiad
reviewed
Mar 13, 2026
| if dd_modalities - acq_modalities: | ||
| parts.append(f"in data_description but not acquisition: {dd_modalities - acq_modalities}") | ||
| warnings.warn( | ||
| f"Modality mismatch between acquisition.data_streams and data_description. {'; '.join(parts)}" |
Collaborator
There was a problem hiding this comment.
but something like "behavior" won't necessarily show up in the data_stream as a modality. How do we handle that?
saskiad
reviewed
Mar 13, 2026
Collaborator
saskiad
left a comment
saskiad
left a comment
There was a problem hiding this comment.
need to handle the behavior exception
Member
Author
|
We've decided to hold on this PR until v3 upgrades. At that time we'll handle via the upgrader repairing all the assets that have behavior in data_description but no corresponding DataStream object. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR validates modalities between:
Errors are raised as warnings. In V3 we will uplevel to validation errors.
While writing tests I also fixed a bug where the "BEFORE" and "AFTER" time validators weren't allowing identical times. This causes problems when people put in their instrument a calibration that occurred at the same time as the acquisition_start_time. I think it's fine for them to be equal since people are just using the start time as a short-hand for "happened as part of this acquisition".