Use imported targets for grid_map_ros - #545
Open
anttix wants to merge 1 commit into
Open
Conversation
Replace ament_target_dependencies with explicit imported-target linking for the grid_map_ros library. The Lyrical ament toolchain no longer accepts the legacy SYSTEM dependency expansion used here. Linking the exported ROS interface targets directly preserves transitive include paths and libraries, while retaining grid_map_cv's legacy variables until that package exports an imported target. This change allows grid_map_ros 2.4.0 to build on ROS 2 Lyrical and removes the need for downstream CMake patches. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
Tick the box to add this pull request to the merge queue (same as
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace the legacy
ament_target_dependencies(... SYSTEM ...)call forgrid_map_roswith explicit imported-target linking.Why
The ROS 2 Lyrical ament toolchain no longer supports this dependency expansion for the library. A Resolute/Lyrical build succeeds when the generated ROS interface targets and exported library targets are linked directly.
This is intentionally narrower than #520: it does not change headers or rosbag APIs. It only modernizes target dependency propagation and can be backported independently for a Lyrical Bloom release.
Tracks #544.