Fix macOS installation by dynamically skipping legacy MaxText directory#3469
Open
igorts-git wants to merge 1 commit intomainfrom
Open
Fix macOS installation by dynamically skipping legacy MaxText directory#3469igorts-git wants to merge 1 commit intomainfrom
igorts-git wants to merge 1 commit intomainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
bvandermoon
reviewed
Mar 20, 2026
Comment on lines
+64
to
+67
| ## macOS Installation | ||
|
|
||
| Due to macOS's case-insensitive filesystem, special care is needed to avoid conflicts between the `maxtext` and legacy `MaxText` package names. We recommend installing it from source using the `.[runner]` configuration. | ||
|
|
Collaborator
There was a problem hiding this comment.
Since you are handling ignoring the src/MaxText files in this PR, does this comment need to be user-facing? Maybe it could just say that only the runner option is supported on MacOS
Collaborator
Author
There was a problem hiding this comment.
OK, I changed the wording here. PTAL.
be0d4a7 to
8d5b43b
Compare
8d5b43b to
ea6c785
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
sys_platform == 'linux'statements from PR #3467FIXES: #3441
Tests
Linux Wheel Parity Test.
To ensure that the generated package for Linux remains exactly the same as before, I ran the following commands on a Linux environment:
Checklist
Before submitting this PR, please make sure (put X in square brackets):
gemini-reviewlabel.