Skip to content

Remove legacy uppercase MaxText from src, to ensure maxtext works on MacOS which has a case-insensitive filesystem.#3467

Open
syrkis wants to merge 2 commits intoAI-Hypercomputer:mainfrom
syrkis:main
Open

Remove legacy uppercase MaxText from src, to ensure maxtext works on MacOS which has a case-insensitive filesystem.#3467
syrkis wants to merge 2 commits intoAI-Hypercomputer:mainfrom
syrkis:main

Conversation

@syrkis
Copy link

@syrkis syrkis commented Mar 20, 2026

Description

This PR makes maxtext work on MacOS, where is currently broken. The removes legacy uppercase MaxText (which was being deprecated anyway) from src/, to ensure maxtext works on MacOS which has a case-insensitive filesystem. Without this, maxtext is broken on MacOS. Additionally, src/MaxText/__init__.py is moved to src/maxtext/__init__.py, and JAX was added as a dependency directly in pyproject.toml. Also basic guarding is added to not try to install CUDA, etc on Mac.

The rest of the description includes relevant details and context, examples:

  • why is this change being made,
  • the problem being solved and any relevant context,
  • why this is a good solution,
  • some information about the specific implementation,
  • shortcomings of the solution and possible future improvements.

FIXES: #3441

Notice 1: Once all tests pass, the "pull ready" label will automatically be assigned.
This label is used for administrative purposes. Please do not add it manually.

Notice 2: For external contributions, our settings currently require an approval from a MaxText maintainer to trigger CI tests.

Tests

I've tested by adding my fork as a dependency to a project on my Linux cluster.

Checklist

Before submitting this PR, please make sure (put X in square brackets):

  • I have performed a self-review of my code. For an optional AI review, add the gemini-review label.
  • I have necessary comments in my code, particularly in hard-to-understand areas.
  • I have run end-to-end tests tests and provided workload links above if applicable.
  • I have made or will make corresponding changes to the doc if needed, including adding new documentation pages to the relevant Table of Contents (toctree directive) as explained in our documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

MaxText seems broken, as importing it throws and error from MaxText itself.

1 participant