Remove legacy uppercase MaxText from src, to ensure maxtext works on MacOS which has a case-insensitive filesystem.#3467
Open
syrkis wants to merge 2 commits intoAI-Hypercomputer:mainfrom
Open
Remove legacy uppercase MaxText from src, to ensure maxtext works on MacOS which has a case-insensitive filesystem.#3467syrkis wants to merge 2 commits intoAI-Hypercomputer:mainfrom
syrkis wants to merge 2 commits intoAI-Hypercomputer:mainfrom
Conversation
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR makes maxtext work on MacOS, where is currently broken. The removes legacy uppercase
MaxText(which was being deprecated anyway) fromsrc/, to ensuremaxtextworks on MacOS which has a case-insensitive filesystem. Without this, maxtext is broken on MacOS. Additionally,src/MaxText/__init__.pyis moved tosrc/maxtext/__init__.py, and JAX was added as a dependency directly in pyproject.toml. Also basic guarding is added to not try to install CUDA, etc on Mac.The rest of the description includes relevant details and context, examples:
FIXES: #3441
Notice 1: Once all tests pass, the "pull ready" label will automatically be assigned.
This label is used for administrative purposes. Please do not add it manually.
Notice 2: For external contributions, our settings currently require an approval from a MaxText maintainer to trigger CI tests.
Tests
I've tested by adding my fork as a dependency to a project on my Linux cluster.
Checklist
Before submitting this PR, please make sure (put X in square brackets):
gemini-reviewlabel.