fix: Caching storage mode validation for modulith and caching service accepts empty password#4805
Open
richard-salac wants to merge 8 commits into
Open
fix: Caching storage mode validation for modulith and caching service accepts empty password#4805richard-salac wants to merge 8 commits into
richard-salac wants to merge 8 commits into
Conversation
Signed-off-by: Richard Salac <richard.salac@broadcom.com>
Signed-off-by: Richard Salac <richard.salac@broadcom.com>
github-project-automation
Bot
moved this to New
in API Mediation Layer Backlog Management
Signed-off-by: Richard Salac <richard.salac@broadcom.com>
…ng_and_vsam' into reboot/fix/caching_service_keyring_and_vsam
pablocarle
reviewed
Jul 15, 2026
| ################################################################################ | ||
|
|
||
| print_formatted_debug "ZWELS" "apiml-service,bin/validate.sh:${LINENO}" "- Checking API ML single service caching storage mode is infinispan" | ||
| validate_this "(storage_mode=\"\${ZWE_components_caching_service_storage_mode:-\${ZWE_configs_storage_mode}}\"; [ -n \"\$storage_mode\" ] && [ \"\$(printf '%s' \"\$storage_mode\" | tr '[:upper:]' '[:lower:]')\" != \"infinispan\" ] && { echo \"API ML single service requires caching storage mode set to infinispan\"; exit 1; }; true; ) 2>&1" "apiml-service,bin/validate.sh:${LINENO}" |
Contributor
There was a problem hiding this comment.
wouldn't it be more robust and readable if it is written as a script and then pass the string result to the validate_this function?
Contributor
Author
There was a problem hiding this comment.
Agreed. It's beautified.
balhar-jakub
moved this from New
to In Progress
in API Mediation Layer Backlog Management
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR is related to potential issues while upgrading v2 to v3.5.
Issues resolved:
Linked to # (issue)
Part of the # (epic)
Type of change
Please delete options that are not relevant.
Checklist:
For more details about how should the code look like read the Contributing guideline