fix: Safkeyring truststore bug fix in certificate-analyzer#4595
Open
hrishikesh-nalawade wants to merge 6 commits intov3.x.xfrom
Open
fix: Safkeyring truststore bug fix in certificate-analyzer#4595hrishikesh-nalawade wants to merge 6 commits intov3.x.xfrom
hrishikesh-nalawade wants to merge 6 commits intov3.x.xfrom
Conversation
Signed-off-by: hrishikesh-nalawade <hrishikesh.nalawade.17@gmail.com>
github-project-automation
Bot
moved this to New
in API Mediation Layer Backlog Management
Signed-off-by: hrishikesh-nalawade <hrishikesh.nalawade.17@gmail.com>
pablocarle
reviewed
Apr 27, 2026
| * On non-z/OS platforms the handler class is simply not found and is ignored. | ||
| */ | ||
| static void ensureSafkeyringHandler() { | ||
| String existing = System.getProperty("java.protocol.handler.pkgs", ""); |
Contributor
There was a problem hiding this comment.
in the start.sh scripts for API ML components we have java.protocol.handler.pkgs always set to com.ibm.crypto.provider. Should we have it the same way also for the analyser?
Member
There was a problem hiding this comment.
If we have the place to push this in, I would say yes.
balhar-jakub
moved this from New
to In Progress
in API Mediation Layer Backlog Management
Member
|
Is the Draft label still intentional? Also do you see adding any unit tests to validate that it won't repeat? |
balhar-jakub
changed the title
|
recaph
reviewed
May 4, 2026
| String existing = System.getProperty("java.protocol.handler.pkgs", ""); | ||
| if (!existing.contains("com.ibm.crypto.provider")) { | ||
| System.setProperty("java.protocol.handler.pkgs", | ||
| existing.isEmpty() ? "com.ibm.crypto.provider" : existing + "|com.ibm.crypto.provider"); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When the certificate-analyser is invoked with a SAF keyring truststore path (e.g. safkeyring://ZWESMVD/ZoweKeyring, type JCERACFKS), the
initTruststore()method inStores.javaalways usesFileInputStreamto open the truststore.The
initKeystore()method in the same class correctly checksisKeyring()and useskeyRingUrl()openStream()for SAF keyrings, but this handling was never added toinitTrustore()Linked to #4592
Type of change
Checklist: