Skip to content

Comments

feat: OpenTelemetry standard attributes#4456

Open
pablocarle wants to merge 61 commits intov3.x.xfrom
reboot/feat/otel-standard
Open

feat: OpenTelemetry standard attributes#4456
pablocarle wants to merge 61 commits intov3.x.xfrom
reboot/feat/otel-standard

Conversation

@pablocarle
Copy link
Contributor

@pablocarle pablocarle commented Jan 16, 2026

Description

Implementation of required / additional / recommended properties for base signals from APIML OpenTelemetry implementation with defaults.

Linked to # (issue)
Part of the # (epic)

Type of change

  • feat: New feature (non-breaking change which adds functionality)

Checklist:

  • My code follows the style guidelines of this project
  • PR title conforms to commit message guideline ## Commit Message Structure Guideline
  • I have commented my code, particularly in hard-to-understand areas. In JS I did provide JSDoc
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • The java tests in the area I was working on leverage @nested annotations
  • Any dependent changes have been merged and published in downstream modules

Pablo Carle added 8 commits January 16, 2026 16:57
Signed-off-by: Pablo Carle <pablo.carle@broadcom.com>
Signed-off-by: Pablo Carle <pablo.carle@broadcom.com>
Signed-off-by: Pablo Carle <pablo.carle@broadcom.com>
Signed-off-by: Pablo Carle <pablo.carle@broadcom.com>
Signed-off-by: Pablo Carle <pablo.carle@broadcom.com>
Signed-off-by: Pablo Carle <pablo.carle@broadcom.com>
Signed-off-by: Pablo Carle <pablo.carle@broadcom.com>
@EvaJavornicka EvaJavornicka moved this from New to In Progress in API Mediation Layer Backlog Management Jan 21, 2026
…andard

Signed-off-by: Pablo Carle <pablo.carle@broadcom.com>
pablocarle

This comment was marked as off-topic.

pablocarle and others added 9 commits January 22, 2026 14:19
Signed-off-by: Richard Salac <richard.salac@broadcom.com>
Signed-off-by: Pablo Carle <pablo.carle@broadcom.com>
Signed-off-by: Pablo Carle <pablo.carle@broadcom.com>
wip
Signed-off-by: Pablo Carle <pablo.carle@broadcom.com>
…andard

Signed-off-by: Pablo Carle <pablo.carle@broadcom.com>
Signed-off-by: Pablo Carle <pablo.carle@broadcom.com>
Pablo Carle added 4 commits February 3, 2026 09:36
Signed-off-by: Pablo Carle <pablo.carle@broadcom.com>
Signed-off-by: Pablo Carle <pablo.carle@broadcom.com>
Signed-off-by: Pablo Carle <pablo.carle@broadcom.com>
Signed-off-by: Pablo Carle <pablo.carle@broadcom.com>
Pablo Carle added 2 commits February 4, 2026 10:08
Signed-off-by: Pablo Carle <pablo.carle@broadcom.com>
Pablo Carle added 4 commits February 10, 2026 13:21
Signed-off-by: Pablo Carle <pablo.carle@broadcom.com>
Signed-off-by: Pablo Carle <pablo.carle@broadcom.com>
Signed-off-by: Pablo Carle <pablo.carle@broadcom.com>
Pablo Carle added 2 commits February 11, 2026 13:13
Signed-off-by: Pablo Carle <pablo.carle@broadcom.com>
Signed-off-by: Pablo Carle <pablo.carle@broadcom.com>
@Value("${apiml.service.apimlId:#{null}}")
protected String apimlId;

public @Nonnull Attributes calculateAttributes() {
Copy link
Contributor

@richard-salac richard-salac Feb 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This method is executed and values generated, but are overridden later.
See io/opentelemetry/sdk/autoconfigure/ResourceConfiguration.java:100

Image

There are multiple resource providers available and our values get overridden. The spi helper loads the providers and orders them.

We need 2 things:

  • our provider must set order to make sure our provider comes last, see io.opentelemetry.sdk.autoconfigure.spi.Ordered#order
  • we need to add an acceptance test

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think these last couple of commits address this issue, thanks

richard-salac and others added 3 commits February 11, 2026 19:33
Signed-off-by: Richard Salač <richard.salac@broadcom.com>
Signed-off-by: Richard Salac <richard.salac@broadcom.com>
Signed-off-by: Richard Salač <richard.salac@broadcom.com>
Signed-off-by: Richard Salac <richard.salac@broadcom.com>
Signed-off-by: Pablo Carle <pablo.carle@broadcom.com>
@sonarqubecloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
50.6% Coverage on New Code (required ≥ 80%)
21.2% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

Pablo Carle and others added 8 commits February 13, 2026 09:36
Signed-off-by: Pablo Carle <pablo.carle@broadcom.com>
Signed-off-by: Richard Salač <richard.salac@broadcom.com>
Signed-off-by: Richard Salac <richard.salac@broadcom.com>
Signed-off-by: Pablo Carle <pablo.carle@broadcom.com>
Signed-off-by: Pablo Carle <pablo.carle@broadcom.com>
Signed-off-by: Pablo Carle <pablo.carle@broadcom.com>
Signed-off-by: Richard Salač <richard.salac@broadcom.com>
Signed-off-by: Richard Salac <richard.salac@broadcom.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: In Progress

Development

Successfully merging this pull request may close these issues.

2 participants