Run the signing tool with dnx instead of installing it - #158
Merged
Conversation
dotnet dnx runs a tool without installing it, so the separate install step is redundant. Matches how efcore-extensions and the adoption docs invoke it. Version stays pinned, now at 1.0.34.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #158 +/- ##
=======================================
Coverage 93.90% 93.90%
=======================================
Files 9 9
Lines 1576 1576
Branches 363 363
=======================================
Hits 1480 1480
Misses 25 25
Partials 71 71 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
dotnet dnxruns a tool without installing it, so the separate install step is redundant. This matches how efcore-extensions and the adoption docs invoke it.The version stays pinned - now
1.0.34, which is the MIT-licensed release.Signing only runs on master with secrets present, so PR CI cannot exercise it; the master run after merge is the real check.