Point at SharpCompress as a worked example - #156
Merged
Merged
Conversation
SharpCompress generates its synchronous methods this way, and the migration notes written while converting it answer the questions someone adopting this in an established codebase actually has: how to prove a generated method is the one it replaced, and when attributing a method would add a member rather than remove a duplicate. Generated with Claude Code
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #156 +/- ##
=======================================
Coverage 93.90% 93.90%
=======================================
Files 9 9
Lines 1576 1576
Branches 363 363
=======================================
Hits 1480 1480
Misses 25 25
Partials 71 71 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Both generate their synchronous methods this way already - FluentValidation since 1.3.8-beta, MiniExcel on 2.0.16. Generated with Claude Code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SharpCompress generates its synchronous methods with this generator as of #1381 and #1383.
Worth linking for the migration notes written while converting it, which answer the questions someone adopting this in a codebase that already has both halves written by hand actually has, and which this repository's own documentation does not:
EmitCompilerGeneratedFiles, diff each generated body against the one deleted from a baseline commit, expect an empty diffRead(Span<byte>)displaces the shimStreamprovides, which is a change in behaviour rather than a deduplication#ifaround framework differences has to be checked in both worlds🤖 Generated with Claude Code