Skip to content

fix(ios): stop interrupting other apps' audio on play and fix session deactivation #894

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
WYSIATI wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(ios): stop interrupting other apps' audio on play and fix session deactivation #894

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 25 additions & 16 deletions ios/RNSound.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,17 @@ - (NSDictionary *)constantsToExport {

RCT_EXPORT_METHOD(setActive:(BOOL)active) {
AVAudioSession *session = [AVAudioSession sharedInstance];
[session setActive:active error:nil];
if (active) {
[session setActive:YES error:nil];
} else {
// Use notifyOthersOnDeactivation so other apps (e.g. Spotify,
// Apple Music) are informed they can resume their audio playback.
// Without this flag, other apps' audio stays paused permanently
// after our session deactivates.
[session setActive:NO
withOptions:AVAudioSessionSetActiveOptionNotifyOthersOnDeactivation
error:nil];
}
}

RCT_EXPORT_METHOD(setMode:(NSString *)modeName) {
Expand Down Expand Up @@ -216,23 +226,22 @@ - (NSString *)categoryForName:(NSString *)categoryName {
}

RCT_EXPORT_METHOD(play:(double)key callback:(RCTResponseSenderBlock)callback) {
[[AVAudioSession sharedInstance] setActive:YES error:nil];

[[NSNotificationCenter defaultCenter]
addObserver:self
selector:@selector(audioSessionChangeObserver:)
name:AVAudioSessionRouteChangeNotification
object:[AVAudioSession sharedInstance]];

[[NSNotificationCenter defaultCenter]
addObserver:self
selector:@selector(audioSessionChangeObserver:)
name:AVAudioSessionInterruptionNotification
object:[AVAudioSession sharedInstance]];

// Audio session activation is left to the app via setCategory/setActive.
// Calling setActive:YES here on every play() call interrupts other apps'
// audio (e.g. Spotify, Apple Music) even when the category is configured
// with mixWithOthers — because the per-play activation triggers iOS audio
// route reconfiguration. Apps should call setActive(true) once during
// setup, not on every play.
//
// Observer registration is also removed. The audioSessionChangeObserver
// auto-resumes playback on AVAudioSessionInterruptionTypeEnded, which
// causes unexpected sound replay after lock screen, phone calls, or Siri.
// Apps that need interruption handling should implement it at the app level
// rather than having the sound library auto-resume behind their back.

self._key = key;
AVAudioPlayer *player = [self playerForKey:key];

if (player) {
NSNumber *myNumber = @(key);
[[self callbackPool] setObject:[callback copy] forKey:myNumber];
Expand Down