Skip to content

Change mixWithOthers type to BOOL in setCategory #892

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dubiao wants to merge 1 commit into
base: master
Choose a base branch
from
+6 −3
Open

Change mixWithOthers type to BOOL in setCategory #892

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions ios/RNSound.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,12 +142,12 @@ - (NSString *)modeForName:(NSString *)modeName {
return modes[modeName];
}

RCT_EXPORT_METHOD(setCategory:(NSString *)categoryName mixWithOthers:(NSNumber *)mixWithOthers) {
RCT_EXPORT_METHOD(setCategory:(NSString *)categoryName mixWithOthers:(BOOL)mixWithOthers) {
AVAudioSession *session = [AVAudioSession sharedInstance];
NSString *category = [self categoryForName:categoryName];

if (category) {
if (mixWithOthers.boolValue) {
if (mixWithOthers) {
[session setCategory:category
withOptions:AVAudioSessionCategoryOptionMixWithOthers | AVAudioSessionCategoryOptionAllowBluetooth
error:nil];
Expand Down Expand Up @@ -176,8 +176,11 @@ - (NSString *)categoryForName:(NSString *)categoryName {
}

#pragma mark - Audio Control Methods

#ifdef RCT_NEW_ARCH_ENABLED
RCT_EXPORT_METHOD(prepare:(NSString *)fileName key:(double)key options:(JS::NativeSoundIOS::SoundOptionTypes &)options callback:(RCTResponseSenderBlock)callback ) {
#else
RCT_EXPORT_METHOD(prepare:(NSString *)fileName key:(double)key options:(NSDictionary *)options callback:(RCTResponseSenderBlock)callback ) {
#endif
NSError *error;
NSURL *fileNameUrl;
AVAudioPlayer *player;
Expand Down