Skip to content

feat: add Feishu delivery config and refresh docs#1

Open
kriptoburak wants to merge 3 commits into
zmlgit:masterfrom
kriptoburak:codex/add-tweetclaw-watchdog-example
Open

feat: add Feishu delivery config and refresh docs#1
kriptoburak wants to merge 3 commits into
zmlgit:masterfrom
kriptoburak:codex/add-tweetclaw-watchdog-example

Conversation

@kriptoburak
Copy link
Copy Markdown

@kriptoburak kriptoburak commented May 14, 2026

Summary

  • Add a TweetClaw companion workflow for long-running X/Twitter monitoring, follower export, giveaway draw, and launch-reply analysis work around OpenClaw subagents or shell helpers.
  • Fix current OpenClaw install command wording and replace the stale OpenClaw badge target.
  • Remove the npm badge/link until openclaw-task-watchdog is published, and add build/typecheck/pack scripts so the dist/ package entry is generated before packing.
  • Address maintainer review by moving Feishu direct delivery behind feishuWebhookUrl and forceFeishu config, defaulting forceFeishu to false, logging webhook failures with warn, and keeping the existing OpenClaw system-event notification path enabled.
  • Document Feishu webhook configuration in README and SKILL without embedding a real webhook URL.

Validation

  • README/SKILL link check: all remaining external links returned 2xx/3xx
  • openclaw.plugin.json parsed as valid JSON
  • added-line scan for real Feishu webhook URLs, secret patterns, stale TweetClaw links, singular OpenClaw install commands, console usage, and non-ASCII dash additions
  • npm install --package-lock=false --ignore-scripts --no-audit --no-fund --registry=https://registry.npmjs.org
  • npm run typecheck
  • npm run build
  • npm run pack:dry-run, verified generated dist/ files are included in the dry-run package output
  • git diff --check

Note

npm ci --ignore-scripts is currently blocked before these changes because package-lock.json resolves dependencies through registry.npmmirror.com, and @mistralai/mistralai@2.2.4 returned 404 from that mirror during validation. The no-lock install above used the public npm registry and did not modify the lockfile.

Copy link
Copy Markdown
Owner

@zmlgit zmlgit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

感谢 PR!方向很好,给 watchdog 加了飞书直推能力。提几个建议:

🔴 必须改:

  1. 飞书 webhook URL 硬编码在代码里(第 42 行 https://open.feishu.cn/open-apis/bot/v2/hook/xxx),应该放到 openclaw.plugin.json 的 configSchema 里,让用户在配置文件中设置

🟡 建议改:
2. notifyViaFeishu() 没有 try-catch,webhook 调用失败会怎样?建议加容错,失败时 log.warn 继续走系统事件通道
3. README 里应该加上飞书 webhook 的配置说明

✅ 做得好的:

  • 没改现有逻辑,纯增量
  • 代码风格和现有代码一致
  • forceFeishu 默认 false 不影响现有用户

建议改完 webhook 配置化后我来 merge。

Copy link
Copy Markdown
Owner

@zmlgit zmlgit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

感谢 PR!方向很好,给 watchdog 加了飞书直推能力。提几个建议:

🔴 必须改:

  1. 飞书 webhook URL 硬编码在代码里,应该放到 openclaw.plugin.json 的 configSchema 里,让用户在配置文件中设置

🟡 建议改:
2. notifyViaFeishu() 没有 try-catch,webhook 调用失败会怎样?建议加容错,失败时 log.warn 继续走系统事件通道
3. README 里应该加上飞书 webhook 的配置说明

✅ 做得好的:

  • 没改现有逻辑,纯增量
  • 代码风格和现有代码一致
  • forceFeishu 默认 false 不影响现有用户

建议改完 webhook 配置化后我来 merge。

Copy link
Copy Markdown
Owner

@zmlgit zmlgit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

感谢 PR!有好的改进也有需要修改的地方。

✅ 可以 merge 的部分:

  • OpenClaw badge 链接修正(nicepkg → openclaw)
  • 去掉未发布的 npm badge
  • 添加 build/typecheck/pack scripts
  • 安装命令修正

🔴 必须修改:

  1. 删除 TweetClaw 推广内容 — README 和 SKILL.md 里的「Companion Workflow: TweetClaw Monitoring」整段以及 openclaw plugins install @xquik/tweetclaw 跟 Task Watchdog 功能无关,不适合放在这里。请移除。

  2. 飞书 webhook 实现缺失 — 加了 feishuWebhookUrlforceFeishu 配置项,但 src/index.mts 里只有 29 行新增且没有实际的 webhook HTTP 调用代码。请补充实现,或移除这两个配置项只保留文档改动。

🟡 建议:
3. em dash → hyphen 的全局替换建议撤销,保持原文风格
4. commit message 建议 feat: 而非 docs:,因为改了 openclaw.plugin.json 和 src/

改完后我可以 merge。

@kriptoburak kriptoburak changed the title docs: add TweetClaw watchdog workflow feat: add Feishu delivery config and refresh docs May 20, 2026
@kriptoburak
Copy link
Copy Markdown
Author

Thanks for the detailed review. I pushed 2d65ada to remove the TweetClaw companion sections from README.md and SKILL.md, so the PR is now scoped to the watchdog/package/docs changes you marked as useful plus the Feishu config and direct-delivery implementation.

Validation after this update:

  • git diff --check
  • removed all TweetClaw/Xquik/@xquik/tweetclaw mentions from the changed public docs
  • package.json and openclaw.plugin.json parse as JSON
  • README/SKILL/package/manifest link check: 4 links checked, 0 failures
  • npm pack --dry-run --json

I could not run npm install/build in this checkout because the existing lockfile resolves the OpenClaw dev dependency chain through @mistralai/mistralai@2.2.4, which currently returns 404 from both npmmirror and the npm registry. I left the lockfile untouched.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants