Skip to content

Update database client installation commands - #829

Open
s-h-a-d-o-w wants to merge 2 commits into
zilliztech:mainfrom
s-h-a-d-o-w:patch-1
Open

Update database client installation commands#829
s-h-a-d-o-w wants to merge 2 commits into
zilliztech:mainfrom
s-h-a-d-o-w:patch-1

Conversation

@s-h-a-d-o-w

Copy link
Copy Markdown
Contributor

A few minor changes:

  • Sort commands alphabetically
  • Add lancedb
  • Make commands copy-pasteable. See:
~/temp/vdbb 10svdbb ❯ uv pip install vectordb-bench[pgvector]
zsh: no matches found: vectordb-bench[pgvector]

~/temp/vdbbvdbb ❯ uv pip install 'vectordb-bench[pgvector]'
Resolved 93 packages in 715ms
Prepared 3 packages in 143ms
Installed 3 packages in 2ms
 + pgvector==0.5.0
 + psycopg==3.3.4
 + psycopg-binary==3.3.4

Please just let me know if you maybe don't want one of these changes and I'll undo that.

Sorted installation commands, added lancedb, made it copy-pasteable
@sre-ci-robot

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: s-h-a-d-o-w
To complete the pull request process, please assign xuanyang-cn after the PR has been reviewed.
You can assign the PR to them by writing /assign @xuanyang-cn in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Comment thread README.md
| doris | `pip install 'vectordb-bench[doris]'` |
| elastic, aliyun_elasticsearch| `pip install 'vectordb-bench[elastic]'` |
| endee | `pip install 'vectordb-bench[endee]'` |
| hologres | `pip install 'vectordb-bench[hologres]'` |

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

README.md line:53
Medium ---- This command requests a hologres extra that is not declared in pyproject.toml, and the same is true of tencent_es on line 66. Pip can still leave the base package installed after warning about an unknown extra, so Hologres's psycopg or Tencent ES's elasticsearch dependency remains missing even though the copy-pasted install appears to complete. Please map these clients to declared dependency groups (for example pgvector / elastic) or add matching extras so the documented commands actually provision the selected client.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with adding the additional entries you mentioned below but I would kindly ask that you take care of these improvements here yourself because I'm not that familiar with this project and all its integrations.

Comment thread README.md
| elastic, aliyun_elasticsearch| `pip install 'vectordb-bench[elastic]'` |
| endee | `pip install 'vectordb-bench[endee]'` |
| hologres | `pip install 'vectordb-bench[hologres]'` |
| lancedb | `pip install 'vectordb-bench[lancedb]'` |

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

README.md line:54
Medium ---- Since this change refreshes the “All the database client supported” inventory, could we also include mariadb, clickhouse, turbopuffer, pinot, and seekdb? Each is registered in the DB/CLI and has a declared optional-dependency key at this head, so leaving them out keeps the supposedly complete, copy-pasteable lookup table out of sync with the integrations users can actually select.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@s-h-a-d-o-w
s-h-a-d-o-w requested a review from yhmo August 4, 2026 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants