Update database client installation commands - #829
Conversation
Sorted installation commands, added lancedb, made it copy-pasteable
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: s-h-a-d-o-w The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
| | doris | `pip install 'vectordb-bench[doris]'` | | ||
| | elastic, aliyun_elasticsearch| `pip install 'vectordb-bench[elastic]'` | | ||
| | endee | `pip install 'vectordb-bench[endee]'` | | ||
| | hologres | `pip install 'vectordb-bench[hologres]'` | |
There was a problem hiding this comment.
README.md line:53
Medium ---- This command requests a hologres extra that is not declared in pyproject.toml, and the same is true of tencent_es on line 66. Pip can still leave the base package installed after warning about an unknown extra, so Hologres's psycopg or Tencent ES's elasticsearch dependency remains missing even though the copy-pasted install appears to complete. Please map these clients to declared dependency groups (for example pgvector / elastic) or add matching extras so the documented commands actually provision the selected client.
There was a problem hiding this comment.
I'm fine with adding the additional entries you mentioned below but I would kindly ask that you take care of these improvements here yourself because I'm not that familiar with this project and all its integrations.
| | elastic, aliyun_elasticsearch| `pip install 'vectordb-bench[elastic]'` | | ||
| | endee | `pip install 'vectordb-bench[endee]'` | | ||
| | hologres | `pip install 'vectordb-bench[hologres]'` | | ||
| | lancedb | `pip install 'vectordb-bench[lancedb]'` | |
There was a problem hiding this comment.
README.md line:54
Medium ---- Since this change refreshes the “All the database client supported” inventory, could we also include mariadb, clickhouse, turbopuffer, pinot, and seekdb? Each is registered in the DB/CLI and has a declared optional-dependency key at this head, so leaving them out keeps the supposedly complete, copy-pasteable lookup table out of sync with the integrations users can actually select.
A few minor changes:
Please just let me know if you maybe don't want one of these changes and I'll undo that.