Skip to content

Fix Skip File Validation When Offline with Existing Datasets #772

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
shaohuasong-fang wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix Skip File Validation When Offline with Existing Datasets #772

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 12 additions & 4 deletions vectordb_bench/backend/data_source.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,9 +86,13 @@ def read(self, dataset: str, files: list[str], local_ds_root: pathlib.Path):
remote_file = pathlib.PurePosixPath("benchmark", dataset, file)
local_file = local_ds_root.joinpath(file)

if (not local_file.exists()) or (not self.validate_file(remote_file, local_file)):
log.info(f"local file: {local_file} not match with remote: {remote_file}; add to downloading list")
# if (not local_file.exists()) or (not self.validate_file(remote_file, local_file)):
# log.info(f"local file: {local_file} not match with remote: {remote_file}; add to downloading list")
if not local_file.exists():
log.info(f"local file: {local_file} not exist; add to downloading list")
downloads.append((remote_file, local_file))
else:
log.info(f"local file: {local_file} already exists, skip download")

if len(downloads) == 0:
return
Expand Down Expand Up @@ -130,9 +134,13 @@ def read(self, dataset: str, files: list[str], local_ds_root: pathlib.Path):
remote_file = pathlib.PurePosixPath(self.remote_root, dataset, file)
local_file = local_ds_root.joinpath(file)

if (not local_file.exists()) or (not self.validate_file(remote_file, local_file)):
log.info(f"local file: {local_file} not match with remote: {remote_file}; add to downloading list")
# if (not local_file.exists()) or (not self.validate_file(remote_file, local_file)):
# log.info(f"local file: {local_file} not match with remote: {remote_file}; add to downloading list")
if not local_file.exists():
log.info(f"local file: {local_file} not exist; add to downloading list")
downloads.append(remote_file)
else:
log.info(f"local file: {local_file} already exists, skip download")

if len(downloads) == 0:
return
Expand Down
Loading