Skip to content

feat: implement Application layer for removing favorites / お気に入り解除のApplication層実装 - #575

Merged
zigzagdev merged 2 commits into
feat/user-favoritefrom
feat/user-favorite-remove-application
Aug 16, 2026
Merged

feat: implement Application layer for removing favorites / お気に入り解除のApplication層実装#575
zigzagdev merged 2 commits into
feat/user-favoritefrom
feat/user-favorite-remove-application

Conversation

@zigzagdev

Copy link
Copy Markdown
Owner

Motivation / 目的

Add the Application-layer use case that removes a favorite, sitting on top of FavoriteRepository::removeFavorite from #572.

#572 で追加した FavoriteRepository::removeFavorite を呼び出すApplication層のUseCaseです。

What I have done / 実施内容

  • Added RemoveFavoriteUseCase::handle(int $userId, int $worldHeritageSiteId): void

Test Results / テスト結果

  • test_handle_calls_repository_removeFavorite_with_given_ids
  • test_handle_propagates_exception_when_user_not_found

Depends on #572

@codecov

codecov Bot commented Aug 16, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 64.46%. Comparing base (63bdf49) to head (7f1caa6).
⚠️ Report is 1 commits behind head on feat/user-favorite.

Additional details and impacted files

Impacted file tree graph

@@                   Coverage Diff                    @@
##             feat/user-favorite     #575      +/-   ##
========================================================
+ Coverage                 64.38%   64.46%   +0.08%     
- Complexity                 1682     1687       +5     
========================================================
  Files                       145      147       +2     
  Lines                      8776     8798      +22     
========================================================
+ Hits                       5650     5672      +22     
  Misses                     3126     3126              
Files with missing lines Coverage Δ
...seCases/UseCase/Favorite/RemoveFavoriteUseCase.php 100.00% <100.00%> (ø)
...ests/CommandUseCases/RemoveFavoriteUseCaseTest.php 100.00% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@zigzagdev zigzagdev left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok

@zigzagdev
zigzagdev merged commit 292614f into feat/user-favorite Aug 16, 2026
28 checks passed
@zigzagdev
zigzagdev deleted the feat/user-favorite-remove-application branch August 16, 2026 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Confirm favorites API endpoint paths (add/list/remove) — frontend and issue docs disagree

1 participant