Skip to content

feat: implement Infra layer for removing favorites / お気に入り解除のInfra層実装 #572

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zigzagdev merged 2 commits into from
Aug 16, 2026
Merged

feat: implement Infra layer for removing favorites / お気に入り解除のInfra層実装 #572

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
eb154e0
feat: add removeFavorite to FavoriteRepository
zigzagdev Aug 16, 2026
63bdf49
test: cover removeFavorite in FavoriteRepositoryTest
zigzagdev Aug 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions src/app/Packages/Domains/Favorite/FavoriteRepository.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,17 @@ public function addFavorite(int $userId, int $worldHeritageSiteId): void
$user->favorites()->attach($worldHeritageSiteId);
}

public function removeFavorite(int $userId, int $worldHeritageSiteId): void
{
$user = $this->userModel->find($userId);

if ($user === null) {
throw new Exception('User not found.');
}

$user->favorites()->detach($worldHeritageSiteId);
}

public function getFavoriteWorldHeritageIds(int $userId): array
{
$user = $this->userModel->find($userId);
Expand Down
2 changes: 2 additions & 0 deletions src/app/Packages/Domains/Favorite/Interface/FavoriteRepositoryInterface.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,5 +6,7 @@ interface FavoriteRepositoryInterface
{
public function addFavorite(int $userId, int $worldHeritageSiteId): void;

public function removeFavorite(int $userId, int $worldHeritageSiteId): void;

public function getFavoriteWorldHeritageIds(int $userId): array;
}
33 changes: 33 additions & 0 deletions src/app/Packages/Domains/Favorite/Tests/FavoriteRepositoryTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,6 +91,39 @@ public function test_addFavorite_throws_exception_when_user_not_found(): void
$this->repository()->addFavorite(999999, $worldHeritage->id);
}

public function test_removeFavorite_detaches_world_heritage_site_from_user(): void
{
$user = $this->seedUser();
$worldHeritage = $this->seedWorldHeritage(1);
$user->favorites()->attach($worldHeritage->id);

$this->repository()->removeFavorite($user->id, $worldHeritage->id);

$this->assertDatabaseMissing('user_favorite', [
'user_id' => $user->id,
'world_heritage_site_id' => $worldHeritage->id,
]);
}

#[\PHPUnit\Framework\Attributes\DoesNotPerformAssertions]
public function test_removeFavorite_does_not_throw_when_not_favorited(): void
{
$user = $this->seedUser();
$worldHeritage = $this->seedWorldHeritage(1);

$this->repository()->removeFavorite($user->id, $worldHeritage->id);
}

public function test_removeFavorite_throws_exception_when_user_not_found(): void
{
$worldHeritage = $this->seedWorldHeritage(1);

$this->expectException(Exception::class);
$this->expectExceptionMessage('User not found.');

$this->repository()->removeFavorite(999999, $worldHeritage->id);
}

public function test_getFavoriteWorldHeritageIds_returns_ids_ordered_by_most_recently_favorited(): void
{
$user = $this->seedUser();
Expand Down
Loading