feat: implement deleteUser in Infra layer / Infra層のdeleteUser実装#521
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## feat/user-delete #521 +/- ##
======================================================
+ Coverage 59.94% 60.01% +0.06%
- Complexity 1515 1519 +4
======================================================
Files 120 120
Lines 7765 7778 +13
======================================================
+ Hits 4655 4668 +13
Misses 3110 3110
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation / 目的
Implement the repository layer for deleting user data as part of the User Delete API (#514).
ユーザー削除APIのInfra層(#515)として、ユーザーデータを削除するリポジトリ層を実装しました。
What I have done / 実施内容
UserRepositroyInterface:deleteUser(int $id): voidを追加UserRepository:deleteUserを実装Exception('User not found.')をスローdelete()でレコードを削除UserRepositoryTest: DBインテグレーションテストを2件追加Test Results / テスト結果
test_deleteUser_removes_user_when_existstest_deleteUser_throws_exception_when_user_not_foundCloses #515