Ensure self._start_time always exists - #5
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #5 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 7 7
Lines 1679 1681 +2
=========================================
+ Hits 1679 1681 +2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
Fixes a runtime crash in ControllerApplication.send_packet() by ensuring _start_time is always defined and guarding against cases where network startup did not set it (e.g., due to a bad tunables configuration).
Changes:
- Initialize
self._start_timein__init__to avoid missing-attribute failures. - Reset
self._start_timeondisconnect(). - Update the route-hint startup-window check in
send_packet()to tolerate_start_timebeing unset.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The bot review on #3 (in a roundabout manner) turned out to be a real issue, not a false positive: a bad
tunablesconfiguration caused this exact bug to occur.