Skip to content

Ensure self._start_time always exists - #5

Merged
puddly merged 1 commit into
devfrom
puddly/fix-start-time
Jul 28, 2026
Merged

Ensure self._start_time always exists#5
puddly merged 1 commit into
devfrom
puddly/fix-start-time

Conversation

@puddly

@puddly puddly commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

The bot review on #3 (in a roundabout manner) turned out to be a real issue, not a false positive: a bad tunables configuration caused this exact bug to occur.

Copilot AI review requested due to automatic review settings July 28, 2026 23:04
@codecov

codecov Bot commented Jul 28, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (77579c9) to head (04556d5).

Additional details and impacted files
@@            Coverage Diff            @@
##               dev        #5   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            7         7           
  Lines         1679      1681    +2     
=========================================
+ Hits          1679      1681    +2     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes a runtime crash in ControllerApplication.send_packet() by ensuring _start_time is always defined and guarding against cases where network startup did not set it (e.g., due to a bad tunables configuration).

Changes:

  • Initialize self._start_time in __init__ to avoid missing-attribute failures.
  • Reset self._start_time on disconnect().
  • Update the route-hint startup-window check in send_packet() to tolerate _start_time being unset.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread zigpy_ziggurat/zigbee/application.py
@puddly
puddly merged commit c92f735 into dev Jul 28, 2026
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants