fix(models): accept telephony platforms (phone, sms, rcs) in SocialAccount - #37
Merged
Merged
Conversation
…count (zernio-claude-plugin#3) GET /v1/accounts returns every connected SocialAccount, including the telephony platforms backing the Phone Numbers product. The generated platform enum only listed social and ads platforms, so the typed accounts.list() path (and the MCP accounts_list core tool) failed pydantic validation for any user with a phone account, while the raw passthrough tool kept working. - add sms, phone, rcs to the SocialAccount platform enum in openapi.yaml and regenerate models (spec fix upstreamed separately so future regens keep the values) - regression tests: AccountsListResponse validates payloads containing phone/sms/rcs accounts and the MCP accounts_list tool returns the full list with fields preserved - bump package to 1.4.508 and SERVICE_VERSION to 1.2.1 (visible at /health) so the deploy is observable Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019c8DtXpqqSunXt4rWRQRTy
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Public issue zernio-dev/zernio-claude-plugin#3: the MCP core tool
accounts_listfails pydantic validation for any user with a connectedphoneaccount. GET /v1/accounts also returns telephony accounts (phone,sms,rcsin the DB enum), but the generated SocialAccount platform enum only listed social and ads platforms. The raw passthrough tool (untyped dict) worked, confirming the API response is valid.What
sms,phone,rcsto the SocialAccount platform enum inopenapi.yamland regenerated modelstests/test_accounts_phone_platform.py):AccountsListResponsevalidates payloads with telephony accounts; MCPaccounts_listreturns the full list with fields preserved (verified failing on old models, passing on new)SERVICE_VERSIONto 1.2.1 (visible at/health) so the deploy is observableFollow-ups
🤖 Generated with Claude Code
https://claude.ai/code/session_019c8DtXpqqSunXt4rWRQRTy