manifest: optional: remove sof from optional manifest by nashif · Pull Request #97946 · zephyrproject-rtos/zephyr

nashif · 2025-10-20T18:51:26Z

Nothing in Zephyr uses SOF, it is the other way round, SOF uses
Zephyr, creating a cyclic dependency in some cases making it difficult
to apply changes to areas used by SOF upstream.

Part of #91061

Signed-off-by: Anas Nashif anas.nashif@intel.com

github-actions · 2025-10-20T18:52:37Z

The following west manifest projects have changed revision in this Pull Request:

Name	Old Revision	New Revision	Diff
sof ❌	zephyrproject-rtos/sof@`ba8de75`	N/A (Removed)	N/A

⛔ DNM label due to: 1 removed project

Note: This message is automatically posted and updated by the Manifest GitHub Action.

nashif · 2025-10-20T20:07:30Z

@LaurentiuM1234 see https://github.com/zephyrproject-rtos/zephyr/actions/runs/18662605621/job/53206439186?pr=97946. You are checking for CONFIG_SOF in various places, this is not correct and is basically a layering violation. SOF is not part of Zephyr and we should not depend on it for hardware configuration. Can can you please take a look and see how you can get this working with check for SOF?

nashif · 2025-10-21T11:42:50Z

@lyakh @kv2019i is this workaround still needed:

zephyr/soc/intel/intel_adsp/Kconfig.defconfig

Line 11 in d7c1ec6

if SOF

lgirdwood

Ack - SOF depends on Zephyr not a cyclic dependency.

kv2019i · 2025-10-21T17:09:48Z

@nashif wrote:

@lyakh @kv2019i is this workaround still needed:

zephyr/soc/intel/intel_adsp/Kconfig.defconfig

Line 11 in d7c1ec6

if SOF

I had no idea we had such a workaround. Any idea who added this comment? Git-blame gives me just the gigantic HWMv2 commit.

It seems this is still depended on, builds will fail if I remove this.

nashif · 2025-10-21T17:17:26Z

I had no idea we had such a workaround. Any idea who added this comment? Git-blame gives me just the gigantic HWMv2 commit.

35a97cb

nashif · 2025-10-22T10:57:45Z

It seems this is still depended on, builds will fail if I remove this.

@kv2019i Is this something we can fix in SOF, ie. in

https://github.com/thesofproject/sof/blob/cb65c6a93e254fc5196f7640e2c47dda0da34a23/src/arch/host/Kconfig#L7

with:

diff --git a/src/arch/host/Kconfig b/src/arch/host/Kconfig
index de92f43a8..5ef3f7420 100644
--- a/src/arch/host/Kconfig
+++ b/src/arch/host/Kconfig
@@ -4,6 +4,6 @@

 config CORE_COUNT
        int
-       default 1
+       default MP_MAX_NUM_CPUS
        help
          Number of used cores

LaurentiuM1234 · 2025-10-22T11:01:08Z

@nashif do you want to have this for v4.3.0? If not, I'll schedule #97988 for v4.4.0

nashif · 2025-10-22T11:02:36Z

@nashif do you want to have this for v4.3.0? If not, I'll schedule #97988 for v4.4.0

we should try and aim for 4.3

nashif · 2025-10-22T11:07:20Z

@nashif do you want to have this for v4.3.0? If not, I'll schedule #97988 for v4.4.0

just added your commits into this PR to get CI to verify all changes in one place.

nashif · 2025-10-22T12:23:06Z

see thesofproject/sof#10321 for changes needed on the SOF side

lyakh · 2025-10-27T14:52:28Z

  labels:
    - "area: Debugging"

-"West project: sof":


typo in commit message: "Nothing in Zephyr uses SOF" was probably meant

Nothing in Zephyr uses SOF, it is the other way round, SOF uses Zephyr, creating a cyclic dependency in some cases making it difficult to apply changes to areas used by SOF upstream. Part of zephyrproject-rtos#91061 Signed-off-by: Anas Nashif <anas.nashif@intel.com>

During transition to HWMv2 this workaround was added, which should instead be in SOF and not in Zephyr, as CORE_COUNT is a SOF Kconfig. Remove this and instead set the CORE_COUNT in SOF to the MP_MAX_NUM_CPUS. Signed-off-by: Anas Nashif <anas.nashif@intel.com>

Do not depend on SOF config, use RIMAGE_SCHEMA instead, defined in SOF. Signed-off-by: Anas Nashif <anas.nashif@intel.com>

sonarqubecloud · 2025-10-27T15:04:38Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

kartben · 2025-11-15T10:28:39Z

@nashif would be nice to add sof as an external module then?

github-actions Bot added manifest manifest-sof DNM (manifest) This PR should not be merged (controlled by action-manifest) labels Oct 20, 2025

nashif force-pushed the topic/modules/optional_to_external_2 branch 2 times, most recently from 7ec8d06 to d691906 Compare October 20, 2025 19:24

LaurentiuM1234 mentioned this pull request Oct 21, 2025

nxp: drop SOF dependencies #97988

Merged

nashif requested review from kv2019i, lgirdwood and lyakh October 21, 2025 11:43

lgirdwood previously approved these changes Oct 21, 2025

View reviewed changes

nashif dismissed lgirdwood’s stale review via aeba174 October 22, 2025 11:06

nashif marked this pull request as ready for review October 22, 2025 11:06

zephyrbot added area: MAINTAINER File area: Boards/SoCs platform: NXP NXP platform: NXP MPU area: Audio platform: Intel ADSP Intel Audio platforms labels Oct 22, 2025

zephyrbot requested review from andyross, ceolin and dbaluta October 22, 2025 11:08

zephyrbot requested review from JiafeiPan, MaureenHelm, Zhiqiang-Hou, dleach02, iuliana-prodan, stephanosio, tmleman and yangbolu1991 October 22, 2025 11:08

zephyrbot assigned MaureenHelm and nashif Oct 22, 2025

zephyrbot added area: Linters area: Continuous Integration labels Oct 22, 2025

nashif force-pushed the topic/modules/optional_to_external_2 branch from efe8831 to 9f338e3 Compare October 22, 2025 12:00

nashif force-pushed the topic/modules/optional_to_external_2 branch from 9f338e3 to 44c214d Compare October 22, 2025 13:08

zephyrbot added the area: West West utility label Oct 22, 2025

lyakh reviewed Oct 27, 2025

View reviewed changes

nashif added 3 commits October 27, 2025 10:59

west_commands: do not depend on CONFIG_SOF

0424ca3

Do not depend on SOF config, use RIMAGE_SCHEMA instead, defined in SOF. Signed-off-by: Anas Nashif <anas.nashif@intel.com>

nashif force-pushed the topic/modules/optional_to_external_2 branch from 44c214d to 0424ca3 Compare October 27, 2025 14:59

dcpleung approved these changes Oct 27, 2025

View reviewed changes

iuliana-prodan approved these changes Oct 27, 2025

View reviewed changes

kv2019i mentioned this pull request Oct 28, 2025

platform: simplify setting CORE_COUNT and MAX_CORE_COUNT thesofproject/sof#10334

Merged

nashif removed the DNM (manifest) This PR should not be merged (controlled by action-manifest) label Nov 14, 2025

MaureenHelm approved these changes Nov 14, 2025

View reviewed changes

kartben merged commit 95b48cd into zephyrproject-rtos:main Nov 15, 2025
44 of 45 checks passed

majunkier mentioned this pull request Nov 17, 2025

INTEL_ADSP: unable to sign after sof removal from manifest #99497

Closed

1 task

Conversation

nashif commented Oct 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Oct 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nashif commented Oct 20, 2025

Uh oh!

nashif commented Oct 21, 2025

Uh oh!

lgirdwood left a comment

Choose a reason for hiding this comment

Uh oh!

kv2019i commented Oct 21, 2025

Uh oh!

nashif commented Oct 21, 2025

Uh oh!

nashif commented Oct 22, 2025

Uh oh!

LaurentiuM1234 commented Oct 22, 2025

Uh oh!

nashif commented Oct 22, 2025

Uh oh!

nashif commented Oct 22, 2025

Uh oh!

nashif commented Oct 22, 2025

Uh oh!

lyakh Oct 27, 2025

Choose a reason for hiding this comment

Uh oh!

sonarqubecloud Bot commented Oct 27, 2025

Quality Gate passed

Uh oh!

kartben commented Nov 15, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

nashif commented Oct 20, 2025 •

edited

Loading

github-actions Bot commented Oct 20, 2025 •

edited

Loading